Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

DM22 Review — Revise Observed DTC in 1st Global Query #1198

Closed ericthomasswenson closed 1 month ago

ericthomasswenson commented 1 year ago

The global DM22 queries are sent with high values in Part 8 and 9. Replace the first of these with the DM12 DTC, as given in the artifact. Revise the Task 5 artifact text to say “use high values” for the second of these. Display the global queries only once.

ericthomasswenson commented 1 year ago

From 3.1.6 with monolithic support.

Start Test 8.12 - DM22: Individual clear/reset of active and previously active DTC 14:35:59.4793 Destination Specific DM22 Request to Engine #1 (0) 14:35:59.4820 18C300F9 [8] 01 FF FF FF FF 66 00 04 (TX) 14:36:00.2297 Timeout - No Response INFO: 6.8.12.6.a - Engine #1 (0) did not provide DM22 CLR_PA_NACK or CLR_ACT_NACK with acknowledgement code of 0

// 6.8.12 DM22: INDIVIDUAL CLEAR/RESET OF ACTIVE AND PREVIOUSLY ACTIVE DTC // 6.8.12.1 Actions // a. DS DM22 (PG 49920) to OBD ECU(s) without a DM12 MIL on DTC stored using the MIL On DTC SPN and FMI and control byte = 17, Request to Clear/Reset Active DTC. // 6.8.12.2 Fail Criteria (if supported) // a.Fail if the ECU provides CLR_PA_ACK or CLR_ACT_ACK (as described in SAE J1939-73 5.7.22). // b.Fail if the ECU provides J1939-21 ACK for PG 49920. // c.Fail if the ECU provides CLR_ACT_NACK or CLR_PA_NACK with an acknowledgement code greater than 0. // 6.8.12.3 Warn Criteria // a.Info: if DM22 (PG 49920) CLR_PA_NACK or CLR_ACT_NACK is not received with an acknowledgement code of 0. // b.Info: if J1939-21 NACK for PG 49920 is received. // A heading for 6.8.12.4 would show the 6.8.12.1 was correctly skipped // 6.8.12.4 Actions2 // a.DS DM22 to OBD ECU with a DM12 MIL on DTC stored using the DM12 MIL On DTC SPN and FMI and control byte = 1, Request to Clear/Reset Previously Active DTC. // 6.8.12.5 Fail Criteria2 // a.Fail if the ECU provides DM22 with CLR_PA_ACK or CLR_ACT_ACK. // b.Fail if the ECU provides J1939-21 ACK for PG 49920. // c.Fail if the ECU provides CLR_ACT_NACK with an acknowledgement code greater than 0. // 6.8.12.6 Warn Criteria2 // a.Info, if DM22 (PG 49920) CLR_PA_NACK or CLR_ACT_NACK is not received with an acknowledgement code of 0. // b.Warn if J1939-21 NACK for PG 49920 is received.

14:36:00.2372 Global DM22 Request 14:36:00.2404 18C3FFF9 [8] 01 FF FF FF FF FF FF FF (TX) 14:36:00.2404 18C3FFF9 [8] 01 FF FF FF FF FF FF FF (TX) Individual Clear/Reset Of Active And Previously Active DTC from Off Board Diagnostic-Service Tool #1 (249): Control Byte: Request to Clear Previously Active DTC (1) Acknowledgement Code: Not Available (255) SPN = 65535; FMI = 31

// Query display repeated // MIL On DTC missing from query

// 6.8.12.7 Actions3 // a.Global DM22 using DM12 MIL On DTC SPN and FMI with control byte = 1, Request to Clear/Reset Previously Active DTC. // 6.8.12.8 Fail Criteria3 // a.Fail if any ECU provides DM22 with CLR_PA_ACK or CLR_ACT_ACK. // b.Fail if any ECU provides J1939-21 ACK for PG 49920. // c.Fail if any ECU provides CLR_ACT_NACK or CLR_PA_NACK with an acknowledgement code greater than 0.

14:36:01.0139 Global DM22 Request 14:36:01.0162 18C3FFF9 [8] 11 FF FF FF FF FF FF FF (TX) 14:36:01.0162 18C3FFF9 [8] 11 FF FF FF FF FF FF FF (TX) Individual Clear/Reset Of Active And Previously Active DTC from Off Board Diagnostic-Service Tool #1 (249): Control Byte: Request to Clear Active DTC (17) Acknowledgement Code: Not Available (255) SPN = 65535; FMI = 31

// DM22 Query was double reported // MIL On DTC missing from query, binary ones is the better choice here.

// 6.8.12.9 Actions4 // a.Global DM22 using DM12 MIL On DTC SPN and FMI with control byte = 17, Request to Clear/Reset Active DTC. // 6.8.12.10 Fail Criteria4 // a.Fail if any ECU provides CLR_PA_ACK or CLR_ACT_ACK. // b.Fail if any ECU provides J1939-21 ACK for PG 49920. // c.Fail if any ECU provides CLR_ACT_NACK or CLR_PA_NACK with an acknowledgement code greater than 0. // d.Fail if any OBD ECU erases any diagnostic information. See Section A.5 for more information.

6.8.12.10.d - Checking for erased diagnostic information 14:36:01.7686 Destination Specific DM6 Request to Engine #1 (0)

ericthomasswenson commented 1 year ago

Start Test 9.3 - DM22: Individual clear/reset of active and previously active DTC 14:39:04.7624 Destination Specific DM22 Request to Engine #1 (0) 14:39:04.7648 18C300F9 [8] 01 FF FF FF FF 66 00 04 (TX) 14:39:05.5119 Timeout - No Response WARN: 6.9.3.6.a - Engine #1 (0) did not provide DM22 CLR_PA_NACK or CLR_ACT_NACK with acknowledgement code of 0

// 6.9.3.1 Actions // a.DS DM22 (PG 49920) to OBD ECU(s) without a DM12 MIL on DTC stored using the MIL On DTC SPN and FMI and control byte = 17, Request to Clear/Reset Active DTC. 6.9.3.2 Fail Criteria (if supported) // a.Fail if the ECU provides CLR_PA_ACK or CLR_ACT_ACK (as described in SAE J1939-73 5.7.22). // b.Fail if the ECU provides J1939-21 ACK for PG 49920. // c.Fail if the ECU provides CLR_ACT_NACK or CLR_PA_NACK with an acknowledgement code greater than 0. // 6.9.3.3 Warn Criteria // a.Warn if DM22 (PG 49920) CLR_PA_NACK or CLR_ACT_NACK is not received with an acknowledgement code of 0. // b.Warn if J1939-21 NACK for PG 49920 is received. // A heading for 6.9.3.4. would show the 6.9.3.1 was correctly skipped // 6.9.3.4 Actions2 // a.DS DM22 to OBD ECU with a DM12 MIL on DTC stored using the DM12 MIL On DTC SPN and FMI and control byte = 1, Request to Clear/Reset Previously Active DTC. // 6.9.3.5 Fail Criteria2 // a.Fail if the ECU provides DM22 with CLR_PA_ACK or CLR_ACT_ACK. // b.Fail if the ECU provides J1939-21 ACK for PG 49920. // c.Fail if the ECU provides CLR_ACT_NACK with an acknowledgement code greater than 0. // 6.9.3.6 Warn Criteria2 // a.Warn if DM22 (PG 49920) CLR_PA_NACK or CLR_ACT_NACK is not received with an acknowledgement code of 0. // b.Warn if J1939-21 NACK for PG 49920 is received.

14:39:06.2716 Global DM22 Request 14:39:06.2756 18C3FFF9 [8] 11 FF FF FF FF FF FF FF (TX) 14:39:06.2756 18C3FFF9 [8] 11 FF FF FF FF FF FF FF (TX) Individual Clear/Reset Of Active And Previously Active DTC from Off Board Diagnostic-Service Tool #1 (249): Control Byte: Request to Clear Active DTC (17) Acknowledgement Code: Not Available (255) SPN = 65535; FMI = 31

// 6.9.3.7 Actions3 // a.Global DM22 using DM12 MIL On DTC SPN and FMI with control byte = 1, Request to Clear/Reset Previously Active DTC. // 6.9.3.8 Fail criteria3: // a.Fail if any ECU provides DM22 with CLR_PA_ACK or CLR_ACT_ACK. // b.Fail if any ECU provides J1939-21 ACK for PG 49920. // c.Fail if any ECU provides CLR_ACT_NACK or CLR_PA_NACK with an acknowledgement code greater than 0.

14:39:05.5173 Global DM22 Request 14:39:05.5202 18C3FFF9 [8] 01 FF FF FF FF FF FF FF (TX) 14:39:05.5202 18C3FFF9 [8] 01 FF FF FF FF FF FF FF (TX) Individual Clear/Reset Of Active And Previously Active DTC from Off Board Diagnostic-Service Tool #1 (249): Control Byte: Request to Clear Previously Active DTC (1) Acknowledgement Code: Not Available (255) SPN = 65535; FMI = 31

// 6.9.3.9 Actions4 // a.Global DM22 using DM12 MIL On DTC SPN and FMI with control byte = 17, Request to Clear/Reset Active DTC. // 6.9.3.10 Fail Criteria4 // a.Fail if any ECU provides CLR_PA_ACK or CLR_ACT_ACK. // b.Fail if any ECU provides J1939-21 ACK for PG 49920. // c.Fail if any ECU provides CLR_ACT_NACK or CLR_PA_NACK with an acknowledgement code greater than > 0. // d.Fail if any OBD ECU erases any diagnostic information. See Section A.5 for more information. // Perhaps binary ones would be the more interesting test here too.

6.9.3.10.d - Checking for erased diagnostic information