search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Add alternation for DM58 testing #1200

Closed ericthomasswenson closed 1 month ago

ericthomasswenson commented 1 year ago

DM58 tests shall only apply for MY 2022+ MY engines. Add alternation to skip this test step otherwise.

13:59:01.6051 Sending DM7 for DM58 to Engine #1 (0) for SPN 102 13:59:01.6091 18E300F9 [8] F5 66 00 1F FF FF FF FF (TX) 13:59:02.3558 Timeout - No Response 13:59:02.3595 18E300F9 [8] F5 66 00 1F FF FF FF FF (TX) 13:59:03.1082 Timeout - No Response 13:59:03.1094 18E300F9 [8] F5 66 00 1F FF FF FF FF (TX) 13:59:03.8572 Timeout - No Response FAIL: 6.1.12.6.a - NACK not received for DM7 PG from OBD ECU Engine #1 (0) for SPN 102 // DM58 Not required for 2018 Engine Model Year

// 6.1.12.5 Actions3, for MY2022+ engines … or for engines that support any SPN for DM58 // a. DS DM7 with TID 245 (for DM58) using FMI 31 for first SP identified as not supporting DM58 // in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. (Use of an SP that supports // test results is preferred when available). // 6.1.12.6 Fail/Warn criteria3: // a. Fail if a NACK is not received

14:08:00.3591 Sending DM7 for DM30 to Engine #1 (0) for SPN 7393 14:08:00.3617 18E300F9 [8] F7 E1 1C 1F FF FF FF FF (TX) 14:08:00.4371 1CA4F900 [12] F7 E1 1C 0A 00 01 00 FB FF FF FF FF DM30 from 0: SPN 7393 FMI 10 (SLOT 256) Result: Test Not Complete. 14:08:00.4504 Sending DM7 for DM58 to Engine #1 (0) for SPN 102 14:08:00.4531 18E300F9 [8] F5 66 00 1F FF FF FF FF (TX) 14:08:01.1997 Timeout - No Response 14:08:01.2032 18E300F9 [8] F5 66 00 1F FF FF FF FF (TX) 14:08:01.9498 Timeout - No Response 14:08:01.9534 18E300F9 [8] F5 66 00 1F FF FF FF FF (TX) 14:08:02.7026 Timeout - No Response FAIL: 6.2.10.7.a - NACK not received for DM7 PG from OBD ECU Engine #1 (0) for SPN 102

// 6.2.10.6 Actions3, for MY2022+ Engines … or for Engines that support any SPNs for DM58 // a. DS DM7 with TID 245 (for DM58) using FMI 31 for first SP identified as not supporting // DM58 in a DM24 response in step 6.1.4.1 to the SP’s respective OBD ECU. (Use of an SP that // supports test results is preferred when available). // 6.2.10.7 Fail/Warn criteria3: // a. Fail if a NACK is not received // Also In 6.12.xx

ericthomasswenson commented 1 year ago

Testing Supported DM58 SPNs is fair game for all engine. Testing for NACK is relevant principally for MY2022+ engines. Current text

Part 1 Text

6.1.12.3 Actions2: // 6.1.12.3 was omitted in error. a. DS DM7 with TID 245 (for DM58) using FMI 31 for each SP identified as supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. b. Display the scaled engineering value for the requested SP. 6.1.12.4 Fail/Warn criteria2: a. Fail if NACK received for DM7 PG from OBD ECU b. Fail, if DM58 not received (after allowed retries) c. Fail, if expected unused bytes in DM58 are not padded with FFh. d. Fail, if data returned is greater than FBh (for 1 byte SP), FBFFh (for 2 byte SP), or FBFFFFFFh (for 4 byte SP). 6.1.12.5 Actions3: a. DS DM7 with TID 245 (for DM58) using FMI 31 for first SP identified as not supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. (Use of an SP that supports test results is preferred when available). 6.1.12.6 Fail/Warn criteria3: a. Fail if a NACK is not received

Part 2 Text

6.2.10.4 Actions2: a. DS DM7 with TID 245 (for DM58) using FMI 31 for each SP identified as supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. b. Display the scaled engineering value for the requested SP. 6.2.10.5 Fail/Warn criteria2: a. Fail if NACK received for DM7 PG from OBD ECU b. Fail, if DM58 not received (after allowed retries) c. Fail, if expected unused bytes in DM58 are not padded with FFh. d. Fail, if data returned is greater than FBh (for 1 byte SP), FBFFh (for 2 byte SP), or FBFFFFFFh (for 4 byte SP). 6.2.10.6 Actions3: a. DS DM7 with TID 245 (for DM58) using FMI 31 for first SP identified as not supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. (Use of an SP that supports test results is preferred when available). 6.2.10.7 Fail/Warn criteria3: a. Fail if a NACK is not received

Part 12 Text

6.12.11.2 Actions2: a. DS DM7 with TID 245 (for DM58) using FMI 31 for each SP identified as supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. b. Display the scaled engineering value for the requested SP. 6.12.11.3 Fail/Warn criteria2: a. Fail if NACK received for DM7 PG from OBD ECU b. Fail, if DM58 not received (after allowed retries) c. Fail, if expected unused bytes in DM58 are not padded with FFh. d. Fail, if data returned is greater than FBh (for 1 byte SP), FBFFh (for 2 byte SP), or FBFFFFFFh (for 4 byte SP). 6.12.11.4 Actions3: a. DS DM7 with TID 245 (for DM58) using FMI 31 for first SP identified as not supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. (Use of an SP that supports test results is preferred when available). 6.12.11.5 Fail/Warn criteria3: a. Fail if a NACK is not received

ericthomasswenson commented 1 year ago

Updated Text:

6.1.12.3 Actions2: for 2022MY+ Engines with SPs indicating DM58 support. // 6.1.12.3 was previously omitted in error. a. DS DM7 with TID 245 (for DM58) using FMI 31 for each SP identified as supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. b. Display the scaled engineering value for the requested SP. 6.1.12.4 Fail/Warn criteria2: for 2022MY+ Engines with SPs indicating DM58 support. a. Fail if NACK received for DM7 PG from OBD ECU b. Fail, if DM58 not received (after allowed retries) c. Fail, if expected unused bytes in DM58 are not padded with FFh. d. Fail, if data returned is greater than FBh (for 1 byte SP), FBFFh (for 2 byte SP), or FBFFFFFFh (for 4 byte SP). 6.1.12.5 Actions3: for 2022MY+ Engines. a. DS DM7 with TID 245 (for DM58) using FMI 31 for first SP identified as not supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. (Use of an SP that supports test results is preferred when available). 6.1.12.6 Fail/Warn criteria3: for 2022MY+ Engines. a. Fail if a NACK is not received

6.12.11.2 Actions2: for 2022MY+ Engines with SPs indicating DM58 support. a. DS DM7 with TID 245 (for DM58) using FMI 31 for each SP identified as supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. b. Display the scaled engineering value for the requested SP. 6.12.11.3 Fail/Warn criteria2: for 2022MY+ Engines with SPs indicating DM58 support. a. Fail if NACK received for DM7 PG with DM58 supported SPN from OBD ECU b. Fail, if DM58 not received (after allowed retries) c. Fail, if expected unused bytes in DM58 are not padded with FFh. d. Fail, if data returned is greater than FBh (for 1 byte SP), FBFFh (for 2 byte SP), or FBFFFFFFh (for 4 byte SP). 6.12.11.4 Actions3: for 2022MY+ Engines a. DS DM7 with TID 245 (for DM58) using FMI 31 for first SP identified as not supporting DM58 in a DM24 response In step 6.1.4.1 to the SP’s respective OBD ECU. (Use of an SP that supports test results is preferred when available). 6.12.11.5 Fail/Warn criteria3: for 2022MY+ Engines a. Fail if a NACK is not received

ericthomasswenson commented 1 year ago

Updated footnote 23 to say:

Test results are expected only from the OBD ECU that listed the SPN with test results supported in its DM24 response. Global queries (DM7 messages) for test results can oversubscribe TP.BAM resources. As the DM7 message is a command, 00E300h is the expected PGN data in a NACK response for DM30 or DM58 requests using DM7. See SAE J1939-21 Appendix B.