search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Add N.1 to Data Stream Failure Message #1202

Closed ericthomasswenson closed 1 month ago

ericthomasswenson commented 1 year ago

Add “N.1” to part 1 test 26 and part 2 test 17 failure messages, like that shown in the example below.

Here SPN 7393 was shown as supported in DM24. N.1 may also be used when FEh is received instead of FFh, and no other notes apply. FEh and FFh are not plausibility warning values.

PGN 64720 with Supported SPNs 7393 14:08:26.7589 18FCD000 [8] FF FF FF FF FF FF FF FF Found: Engine Particulate Sensor Information from Engine #1 (0): SPN 5835, AFT 1 Particulate Sensor: Not Available SPN 5836, AFT 2 Particulate Sensor: Not Available SPN 7393, AFT 1 Particulate Sensor Current: Not Available

FAIL: 6.2.17.6.b - SPN 7393 was received as NOT AVAILABLE from Engine #1 (0)

// Add N.1 to above i.e. “6.2.17.6.b - N.1 SPN 7393 …”

battjt commented 1 year ago

N.1 should be referenced from 6.1.26.6.a. Fails and warnings in 6.1.26.5 and 6 have changed are have bugs witth the identifiers of what is reported (N.1 is not referenced and the requirement numbers are off, but the logic appears to be correct).

N.8 is correctly referenced from 6.1.26.6.b.

battjt commented 1 year ago

The Error labeled as N.8 in 6.1.26.6.b was changed to N.1 and N/A failures are now also listed as N.1. All failures in the the "A1 validator" now have table labels.