search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

6.7.16.4.c Incorrect Warn issued by the tool #1206

Closed anthonyhbest closed 1 month ago

anthonyhbest commented 1 year ago

Version 3.1.6 and 3.1.7 of the tool are issuing an incorrect warn at part 6.7.16.4.c based on the specification: image

This seems to be coded incorrectly in the tool as the tool is issuing a WARN but the ECU responded with control byte = 1.

image

battjt commented 1 year ago

Same error also found in 6.8.13.2.c. We will review all NACK comparisons.

ericthomasswenson commented 1 year ago

See #1199, The transposition of b. and c. should take care this.

Interceding NACK messages may be creating this failure.

Transposition documented in v2 artifact.