search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

CAL IDs Padded with 00h Shall Pass #1253

Closed ericthomasswenson closed 10 months ago

ericthomasswenson commented 1 year ago

Padding with 00h is required for CAL IDs in 5.7.19.2

_In the instance where a CAL ID and CVN has not ever been reported by a subnetwork device then the controller responding with the information to the scan tool shall report the CAL ID as sixteen bytes of FFh and the CVN as all zeros in the position in the string that would have been sent to the scan tool. Data Length: 16 bytes Resolution: Not applicable Data Range: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00h to FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FFh Type: ASCII and limited to printable characters only, except that 00h used as padding at the end for a CAL ID less than 16 bytes Suspect Parameter Number: 1635 Reference: 5.7.19_

ericthomasswenson commented 1 year ago

6.1.7.2 Fail Criteria a. Fail if total number of reported CAL IDs is < user entered value for number of emission or diagnostic critical control units (test 6.1.2). b. For responses from OBD ECUs: i. Fail if <> 1 CVN for every CAL ID. ii. Fail if CAL ID not formatted correctly (printable ASCII, padded incorrectly, etc.). iii. Fail if any received CAL ID is all FFh iv. Fail if or any CVN received is all 00h. iv. Fail if CVN padded with 16-binary zeros (where either the 1st two bytes are both 00h or the last two bytes both 00h). Note HD OBD CVNs are required to be 32-bits.incorrectly (padding shall use 00h in MSB for unused bytes).

Add footnote to b.ii.

Acceptable padding shall include 20h and 00h. 00h is required by J1939-73 5.7.19.2

ericthomasswenson commented 1 year ago

See #1120 for last improvement attempt.