search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Centralized reporting of DTC Counts in DM29 creates false positive results #1256

Open ericthomasswenson opened 1 year ago

ericthomasswenson commented 1 year ago

Centralized reporting of DTC Counts in DM29 creates false positive results when the fault is implanted in another device than the one provided centralized reporting.

Start Test 5.5 - DM29: Regulated DTC counts 07:26:19.2177 Global DM29 Request 07:26:19.2215 18EAFFF9 [3] 00 9E 00 (TX) 07:26:19.2484 189EFF00 [8] 00 00 01 00 01 FF FF FF DM29 from Engine #1 (0): Emission-Related Pending DTC Count 0 All Pending DTC Count 0 Emission-Related MIL-On DTC Count 1 Emission-Related Previously MIL-On DTC Count 0 Emission-Related Permanent DTC Count 1

FAIL: 6.5.5.2.c - Engine #1 (0) reported a different number of MIL on DTCs than what it reported in DM12 earlier in this part FAIL: 6.5.5.2.d - Engine #1 (0) reported a different number of permanent DTCs than what it reported in DM28 earlier in this part // DTC counts are correct. The false failure is an artifiact of // Centralized reporting of DTC counts in DM29.

also FAIL: 6.7.10.2.c - Engine #1 (0) reported a different number of previous MIL on DTCs that what it reported in DM23 earlier in this part

Emission-Related MIL-On DTC Count 1 Emission-Related Previously MIL-On DTC Count 1 Emission-Related Permanent DTC Count 1

FAIL: 6.8.8.2.c - Engine #1 (0) reported a different number for MIL on than what it reported in DM12 earlier in this part FAIL: 6.8.8.2.e - Engine #1 (0) reported a different number for previous MIL on than what it reported in DM23 earlier in this part FAIL: 6.8.8.2.g - Engine #1 (0) reported a different number for permanent than what it reported in DM28 earlier in this part // The DTC Counts are correct // The failures are a artifact of centralized DM29 support

FAIL: 6.9.15.2.c - Engine #1 (0) reported different number for permanent DTC than what it reported in DM28 // The DTC Counts are correct // The failures are a artifact of centralized DM29 support

ericthomasswenson commented 1 year ago

Correct with DM29 improvements with multiple fault implants.

Something like, fail if the sum of DMXX DTCs counted in DMXX displays is greater than the sum of the corresponding DM29 counts.

Should work for both centralized reporting and multiple fault implants.

ericthomasswenson commented 1 year ago

Also observed for SA 61 detected faults in addition to SA 39

Start Test 5.5 - DM29: Regulated DTC counts 12:52:52.5735 Global DM29 Request 12:52:52.5754 18EAFFF9 [3] 00 9E 00 (TX) 12:52:52.6030 189EFF00 [8] 00 00 01 00 01 FF FF FF DM29 from Engine #1 (0): Emission-Related Pending DTC Count 0 All Pending DTC Count 0 Emission-Related MIL-On DTC Count 1 Emission-Related Previously MIL-On DTC Count 0 Emission-Related Permanent DTC Count 1

FAIL: 6.5.5.2.c - Engine #1 (0) reported a different number of MIL on DTCs than what it reported in DM12 earlier in this part FAIL: 6.5.5.2.d - Engine #1 (0) reported a different number of permanent DTCs than what it reported in DM28 earlier in this part

ericthomasswenson commented 1 year ago

Passed on another occasion.

DM23 from Engine #1 (0): MIL: off, RSL: off, AWL: off, PL: not supported, No DTCs 13:29:09.3718 Destination Specific DM29 Request to Engine #1 (0) 13:29:09.3747 18EA00F9 [3] 00 9E 00 (TX) 13:29:09.4061 189EF900 [8] [00 00 00 00 00](tel:00 00 00 00 00) FF FF FF DM29 from Engine #1 (0): Emission-Related Pending DTC Count 0 All Pending DTC Count 0 Emission-Related MIL-On DTC Count 0 Emission-Related Previously MIL-On DTC Count 0 Emission-Related Permanent DTC Count 0 13:29:09.4069 Destination Specific DM5 Request to Engine #1 (0) 13:29:09.4097 18EA00F9 [3] CE FE 00 (TX) 13:29:09.4116 18FECE00 [8] [00 00 14 27](tel:00 00 14 27) E0 0E E0 0E DM5 from Engine #1 (0): OBD Compliance: HD OBD (20), Active Codes: 0, Previously Active Codes: 0

ericthomasswenson commented 1 year ago

Implement in Task 8, budget permitting… high priority.