Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

DM29 Response not credited as received … NACK from SA84 is noise #1261

Closed ericthomasswenson closed 1 month ago

ericthomasswenson commented 11 months ago

// DM29 Response not credited as received …

Start Test 1.22 - DM29: Regulated DTC counts 11:09:03.5836 Global DM29 Request 11:09:03.5857 18EAFFF9 [3] 00 9E 00 (TX) 11:09:03.5877 18E8FF54 [8] 01 00 FF FF FF 00 9E 00 Acknowledgment from Cab Display #2 (84): Response: NACK, Group Function: 0, Address Acknowledged: 255, PGN Requested: 40448 // This response is noise

FAIL: 6.1.22.2.d - No OBD ECU provided DM29 11:09:04.3366 Destination Specific DM29 Request to Engine #1 (0) 11:09:04.3390 18EA00F9 [3] 00 9E 00 (TX) 11:09:05.0866 Timeout - No Response 11:09:05.0866 Destination Specific DM29 Request to Management Computer #1 (39) 11:09:05.0902 18EA27F9 [3] 00 9E 00 (TX) 11:09:05.0947 18E8FF27 [8] 01 FF FF FF F9 00 9E 00 Acknowledgment from Management Computer #1 (39): Response: NACK, Group Function: 255, Address Acknowledged: 249, PGN Requested: 40448 11:09:05.0947 Destination Specific DM29 Request to Exhaust Emission Controller (61) 11:09:05.0974 18EA3DF9 [3] 00 9E 00 (TX) 11:09:05.1126 1CE8FF3D [8] 01 FF FF FF F9 00 9E 00 Acknowledgment from Exhaust Emission Controller (61): Response: NACK, Group Function: 255, Address Acknowledged: 249, PGN Requested: 40448 FAIL: 6.1.22.4.b - OBD ECU Engine #1 (0) did not provide a response to Global query and did not provide a NACK for the DS query // Potential tool Issue … SA 84 NACK was Noise.

ericthomasswenson commented 11 months ago

Add unit test for tp stack to insure responses are received after NACK is received.

Add W label