Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Required Data Stream Info instead of Warn #1263

Closed anthonyhbest closed 1 month ago

anthonyhbest commented 9 months ago

@ericthomasswenson, is it possible to have some of the lesser supported SPNs changed from Warn to Info in the tool, for instance, SPN 12758 "Target Fresh Air Mass Flow"? Some manufacturers may be utilizing this message, but it is not commonly utilized on CI engines. This results in a Warn from the tool, but since the regulations states "For all engines so equipped" at the beginning of section (h)4.2.3 would it be possible to adjust this to an Info?

ericthomasswenson commented 9 months ago

Eric will review v. Table A-1 and respond with a new comment. No other participants object to this suggestion.

battjt commented 7 months ago

Waiting on verification from Halfman.

ericthomasswenson commented 7 months ago

13 CCR 1971.1 (h)(4.2.3) For all engines so equipped: (h)(4.2.3)(G) For 2024 and subsequent model year engines, commanded DEF dosing, DEF dosing mode (A, B, C, etc.), DEF dosing rate, DEF usage for current driving cycle, target ammonia storage level on SCR, modeled actual ammonia storage level on SCR, SCR intake temperature, SCR outlet temperature, stability of NOx sensor reading, EGR mass flow rate, engine fuel rate, vehicle fuel rate, hydrocarbon doser flow rate, hydrocarbon doser injector duty cycle, aftertreatment fuel pressure, charge air cooler outlet temperature, propulsion system active, chassis odometer reading, engine odometer reading (if available), hybrid/EV charging state, hybrid/EV battery system voltage, hybrid/EV battery system current, commanded/target fresh air flow, crankcase pressure sensor output, crankcase oil separator rotational speed, evaporative system purge pressure sensor output, and vehicle speed limiter speed limit.

ericthomasswenson commented 7 months ago

The subject line is marked CI and 2024.

<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">

| 12758 (24) | Target Fresh Air Mass Flow (CI) | 61450 | 50 ms | No | Warn(CI) | No | Fail | Fail | Fail | NA | NA |

There is an argument whether SPN 12758 is or is not the best ‘lead’ SPN for PG 61450. If not, then column 10 would be better coded as Warn instead of Fail, when PG 61450 is provided including SPN 12758.

ericthomasswenson commented 7 months ago

Other SPs included in PG 61450:

<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">

| 2659 (24) | Engine Exhaust Gas Recirculation 1 Mass Flow Rate | 61450 | 50 ms | No | Warn | No | Fail | Fail | Fail | > 0 | NA |

<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">

| 132 | Engine Intake Air Mass Flow Rate | 61450 | BC 50ms | No | Warn | Warn | Fail | Fail | Warn | > 0.20 kg/hr | <= 0 kg/hr |

ericthomasswenson commented 7 months ago

Of these, SPN 132 would appear to be the better lead SP when supported … followed by SPN 2659.

ericthomasswenson commented 7 months ago

Whereas logical alternatives to SPN 12758 as the lead SPN for PG 12758 exist, column 10 is better coded as Warn for SPN 12758.

| 12758 (24) | Target Fresh Air Mass Flow (CI) | 61450 | 50 ms | No | Warn(CI) | No | Fail | Fail | Warn | NA | NA |

ericthomasswenson commented 6 months ago

Also change 2659 to warn.

| 2659 (24) | Engine Exhaust Gas Recirculation 1 Mass Flow Rate | 61450 | 50 ms | No | Warn | No | Fail | Fail | Warn | > 0 | NA |

ericthomasswenson commented 6 months ago

Also delete (CI) from

| 12758 (24) | Target Fresh Air Mass Flow (CI) | 61450 | 50 ms | No | Warn(CI) | No | Fail | Fail | Warn | NA | NA |

in addition to changing Fail to Warn in ‘column 10’.