search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Test that runs KOEO fails as not erased in 6.9.10 #1307

Closed ericthomasswenson closed 1 month ago

ericthomasswenson commented 4 months ago

3.1.25

Part 1 - Expected

13:47:17.1616 Sending DM7 for DM30 to Engine #1 (0) for SPN 6772 13:47:17.1645 18E300F9 [8] FA 74 1A 0C FF FF FF FF (TX) 13:47:17.1818 1CA4F900 [12] FA 74 1A 0C 0C 00 00 00 00 00 FF FF DM30 from Engine #1 (0): SPN 6772 FMI 12 (SLOT 12) Result: Test Passed. Min: N/A, Value: 0, Max: 0 count FAIL: 6.9.10.2.a - Engine #1 (0) reported test result for SPN = 6772, FMI = 12 is not initialized

Is expected to be recorded in part 1 and pass after erase checks later

Part 9

13:47:05.6849 Global DM11 Request 13:47:05.6872 18EAFFF9 [3] D3 FE 00 (TX) 13:47:05.6876 18E8FF17 [8] 00 FF FF FF F9 D3 FE 00 ... 13:47:17.1616 Sending DM7 for DM30 to Engine #1 (0) for SPN 6772 13:47:17.1645 18E300F9 [8] FA 74 1A 0C FF FF FF FF (TX) 13:47:17.1818 1CA4F900 [12] FA 74 1A 0C 0C 00 00 00 00 00 FF FF DM30 from Engine #1 (0): SPN 6772 FMI 12 (SLOT 12) Result: Test Passed. Min: N/A, Value: 0, Max: 0 count FAIL: 6.9.10.2.a - Engine #1 (0) reported test result for SPN = 6772, FMI = 12 is not initialized

It looks like we may have missed one spot to excuse tests that run KOEO

ericthomasswenson commented 4 months ago

See #1039

ericthomasswenson commented 3 months ago

Also #1300 … still present on

J1939-84 Tool version 3.1.26 - 2024/02/04 12:03

ericthomasswenson commented 1 month ago

Mark M. Reported today that test results issues appear to be fixed in 3.1.28