Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Info not provided for Non-OBD modules as defined for 6.1.3.3.c #1308

Closed ericthomasswenson closed 6 months ago

ericthomasswenson commented 9 months ago

Info not provided for Non-OBD modules as defined for 6.1.3.3.c

6.1.3.3 Warn/Info Criteria a. Warn if more than one ECU responds with a value for OBD compliance where the values are not identical (e.g., if one ECU reports 13h and another reports 22h, if one reports 13h and another reports 11h, or if one ECU reports 00h and another reports 14h). b. Warn if any response received from a non-OBD ECU provides OBD Compliance values of 0, FBh, FCh, FDh, FEh, or FFh. c. Info for DM5 replies from non-OBD ECUs. // The above changes incorporate #1099

Original request in #968

https://github.com/Equipment-and-Tool-Institute/j1939-84/assets/94923793/d77789b5-7253-40c8-b2d0-7fac36803097

ericthomasswenson commented 9 months ago

From 3.1.26

Vehicle Composite of DM5: Comprehensive component Fuel System Misfire EGR/VVT system Exhaust Gas Sensor heater Exhaust Gas Sensor … supported, not complete supported, not complete supported, not complete supported, not complete not supported, complete

INFO: 6.1.3.3.c - Response received from a non-OBD ECU provided OBD Compliance values of 5h INFO: 6.1.3.3.c - Response received from a non-OBD ECU provided OBD Compliance values of 5h INFO: 6.1.3.3.c - Response received from a non-OBD ECU provided OBD Compliance values of 5h

ericthomasswenson commented 9 months ago

Perhaps we add the SA to the info message

Joe, please respond with an estimate

karysg commented 9 months ago

If adding the SA is the only request, estimate is 2-4 hours.

battjt commented 9 months ago

I think the check is done in two different places.

Both should be info.

anthonyhbest commented 6 months ago

@ericthomasswenson DM5 issue is still present in version 3.1.28 The following should be INFO not WARN per the agreed upon WARN/INFO criteria as mentioned above.

image image