Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Tool is issuing incorrect Timing: Late Responses #1314

Closed anthonyhbest closed 1 month ago

anthonyhbest commented 3 months ago

V3.1.20 of Tool is issuing timing late responses incorrectly: image image

anthonyhbest commented 3 months ago

And again: image image

anthonyhbest commented 3 months ago

And again: image

ericthomasswenson commented 3 months ago

I may have seen a similar complaint:

TIMING: Late response - 14:37:26.6447 18E8FF54 [8] 01 00 FF FF FF 82 FD 00 TIMING: Late response - 14:37:26.6461 18E8FF4C [8] 01 00 FF FF FF 82 FD 00 TIMING: Late response - 14:37:26.6506 18FD8200 [8] 43 FF 00 00 00 00 FF FF TIMING: Late response - 14:37:26.6567 18FD8227 [8] 03 FF 00 00 00 00 FF FF TIMING: Late response - 14:37:26.6616 18FD823D [8] 03 FF 00 00 00 00 FF FF

battjt commented 2 months ago

I think all of Anthony's late responses are related to conflicts between the DM5 heartbeat request and the report. That would make Eric's report a separate bug. I will need a report and the .ASC file to diagnose that.

  1. I am still investigating why the request time is after the response.
  2. I will look into how to avoid conflicting DM5 requests and the DM5 heartbeat.
battjt commented 1 month ago

Looks like the DM5 heartbeat stop() wasn't waiting for the stop to complete.