Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Add Adapter Selection to Report Heading #1326

Closed ericthomasswenson closed 1 month ago

ericthomasswenson commented 2 months ago

Add “Adapter Selection:” to Report Heading

Insert “Adaptor Selection:” After Generated … and Before Log File Name

This is a conceptual error of omission from prior work.

Please define a format that will be unambiguous… This may display content commonly found in an RP1210 .INI file and/or the file name and path.

Current report displays…

Summary of J1939-84 Tool Execution

J1939-84 Tool version 3.1.26 - 2024/02/04 12:03 Generated: 2024/03/13 15:19:53.1072 Log File Name: C:\CdriveSave\new j1939-84\E44 RC2 ECM faults_13mar2024.txt

TEST SUMMARY REPORT OUTCOME: Failures: 23 Warnings: 20 Information: 34 Incomplete: 0 Timing: 5 Passes: 154

User Data Entry:

karysg commented 2 months ago

Proposed format Adapter Selection: DLL - ADAPTER NAME

J1939-84 Tool version 3.1.26 - 2024/02/04 12:03 Generated: 2024/03/13 15:19:53.1072 Adapter Selection: NXULNK32 - NEXIQ Technologies USB-Link - USB-Link Log File Name: C:\CdriveSave\new j1939-84\E44 RC2 ECM faults_13mar2024.txt

ericthomasswenson commented 2 months ago

Looks nice … Please implement this example (INI/DLL name || Dropdown menu string) in both software sets.

ericthomasswenson commented 1 month ago

Confirmed observation in 3.1.28