Engine Revs Conversion Incorrect

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org

MIT License

7 stars 6 forks source link

Engine Revs Conversion Incorrect #1329

Closed ericthomasswenson closed 7 months ago

ericthomasswenson commented 7 months ago

Engine Revs Conversation Incorrect

0503CBh is 328651 decimal. Decimal point is in the wrong place.

14:29:13.3561 Destination Specific for PGN 65253 for SPNs Request to Engine #1 (0) 14:29:13.3577 18EA00F9 [3] E5 FE 00 (TX) 14:29:13.3661 18FEE500 [8] A2 90 01 00 CB 03 05 00 Engine Hours, Revolutions from Engine #1 (0): SPN 247, Engine Total Hours of Operation: 5128.100 h SPN 249, Engine Total Revolutions: 328651000.000 r

karysg commented 7 months ago

The J1939DA SLOT (id 34) for SPN 249 has a scale factor of 1000, should this be changed? @ericthomasswenson

ericthomasswenson commented 7 months ago

Correct … that’s a bit per minute at 1000 rpm … it just looked odd …