search

Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Contract Artifact Check #1334

Open ericthomasswenson opened 5 months ago

ericthomasswenson commented 5 months ago

Review contract artifact for mismatches with existing released code before starting C3 changes.

karysg commented 4 months ago

2.1.2 (pg 9) broken link http://www.arb.ca.gov/msprog/obdprog/obdregs.htm

6.1.3.3.b missing 0x5 from list of OBD Compliance values (compared to 6.1.3.1.b) Present in code and doc.

6.1.4.2.f (pg 26) in doc: WARN in code: INFO

6.1.11.2.a & 6.1.11.2.b, 6.1.11.4.a & 6.1.11.4.b swapped in code getKmSinceDTCsCleared() vs getKmWhileMILIsActivated()

6.1.17.1.a in doc: PG 65227 for DM6 should be 65231 Code is correct. also appears in: 6.3.2.1.a, 6.7.7.1.a, 6.4.8.1, 6.9.20.1.a

6.2.8.2.b (pg 48) 6.2.8.2.b in code as 6.2.8.3.b, functionality and description correct only step name is incorrect

6.2.10.4.a (pg 49) missing from code

6.6.8.2.e (pg 74) description in code uses 'number' instead of 'count' also appears in: 6.8.8.2.c, 6.8.8.2..e, 6.8.8.2..g, 6.9.15.2.c

6.8.13.2.c (pg 87) missing in code

6.12.2.2.a (pg 107) in doc: WARN in code: INFO

karysg commented 4 months ago

2.1.2 (pg 9) broken link http://www.arb.ca.gov/msprog/obdprog/obdregs.htm

No Action: document is correct 6.1.3.3.b missing 0x5 from list of OBD Compliance values (compared to 6.1.3.1.b) Present in code and doc.

No Action: code consistent with latest document 6.1.4.2.f (pg 26) in doc: WARN in code: INFO

Resolved: fixing in code 6.1.11.2.a & 6.1.11.2.b, 6.1.11.4.a & 6.1.11.4.b swapped in code getKmSinceDTCsCleared() vs getKmWhileMILIsActivated()

Resolved: document corrected 6.1.17.1.a in doc: PG 65227 for DM6 should be 65231 Code is correct. also appears in: 6.3.2.1.a, 6.7.7.1.a, 6.4.8.1, 6.9.20.1.a

No Action: code consistent with latest document 6.2.8.2.b (pg 48) 6.2.8.2.b in code as 6.2.8.3.b, functionality and description correct only step name is incorrect

No Action: document and code are correct 6.2.10.4.a (pg 49) missing from code

No Action: no need to update code at this time 6.6.8.2.e (pg 74) description in code uses 'number' instead of 'count' also appears in: 6.8.8.2.c, 6.8.8.2..e, 6.8.8.2..g, 6.9.15.2.c

No Action: code consistent with latest document 6.8.13.2.c (pg 87) missing in code

Resolved: document updated 6.12.2.2.a (pg 107) in doc: WARN in code: INFO