Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Investigate Step13 logic per feedback #224

Closed mmschaefer closed 3 years ago

mmschaefer commented 4 years ago

Per client feedback:

Part 1.13 DM5 functionality is off. It should provide a single composite table of all readiness from all controllers reporting . It provided an individual table for each controller that reported except SA00.

Start Step 1.13. DM5: Diagnostic Readiness 1: Monitor Readiness 09:23:47.7163 Global DM5 Request 09:23:47.7163 18EAFFF9 CE FE 00 (TX) 09:23:47.7253 18FECE00 00 00 14 37 E0 1E E0 1E DM5 from Engine #1 (0): OBD Compliance: HD OBD (20), Active Codes: 0, Previously Active Codes: 0 09:23:47.7296 18FECE03 00 00 05 00 00 00 00 00 DM5 from Transmission #1 (3): OBD Compliance: Not intended to meet OBD II requirements (5), Active Codes: 0, Previously Active Codes: 0 09:23:47.7382 18FECE19 00 00 05 00 00 00 00 00 DM5 from Passenger-Operator Climate Control #1 (25): OBD Compliance: Not intended to meet OBD II requirements (5), Active Codes: 0, Previously Active Codes: 0 09:23:47.7546 18FECE17 00 00 05 00 00 00 00 00 DM5 from Instrument Cluster #1 (23): OBD Compliance: Not intended to meet OBD II requirements (5), Active Codes: 0, Previously Active Codes: 0 PASS: 6.1.13.1.a Global DM5 Vehicle Composite DM5 Response from Transmission #1 (3) A/C system refrigerant not supported, completed Boost pressure control sys not supported, completed Catalyst not supported, completed Cold start aid system not supported, completed Comprehensive component not supported, completed Diesel Particulate Filter not supported, completed EGR/VVT system not supported, completed Evaporative system not supported, completed Exhaust Gas Sensor not supported, completed Exhaust Gas Sensor heater not supported, completed Fuel System not supported, completed Heated catalyst not supported, completed Misfire not supported, completed NMHC converting catalyst not supported, completed NOx catalyst/adsorber not supported, completed Secondary air system not supported, completed DM5 Response from Passenger-Operator Climate Control #1 (25) A/C system refrigerant not supported, completed Boost pressure control sys not supported, completed Catalyst not supported, completed Cold start aid system not supported, completed Comprehensive component not supported, completed Diesel Particulate Filter not supported, completed EGR/VVT system not supported, completed Evaporative system not supported, completed Exhaust Gas Sensor not supported, completed Exhaust Gas Sensor heater not supported, completed Fuel System not supported, completed Heated catalyst not supported, completed Misfire not supported, completed NMHC converting catalyst not supported, completed NOx catalyst/adsorber not supported, completed Secondary air system not supported, completed DM5 Response from Instrument Cluster #1 (23) A/C system refrigerant not supported, completed Boost pressure control sys not supported, completed Catalyst not supported, completed Cold start aid system not supported, completed Comprehensive component not supported, completed Diesel Particulate Filter not supported, completed EGR/VVT system not supported, completed Evaporative system not supported, completed Exhaust Gas Sensor not supported, completed Exhaust Gas Sensor heater not supported, completed Fuel System not supported, completed Heated catalyst not supported, completed Misfire not supported, completed NMHC converting catalyst not supported, completed NOx catalyst/adsorber not supported, completed Secondary air system not supported, completed 09:23:48.9722 Global DM5 Request 09:23:48.9722 18EAFFF9 CE FE 00 (TX) 09:23:48.9792 18FECE03 00 00 05 00 00 00 00 00 DM5 from Transmission #1 (3): OBD Compliance: Not intended to meet OBD II requirements (5), Active Codes: 0, Previously Active Codes: 0 09:23:48.9855 18FECE00 00 00 14 37 E0 1E E0 1E DM5 from Engine #1 (0): OBD Compliance: HD OBD (20), Active Codes: 0, Previously Active Codes: 0 09:23:48.9932 18FECE17 00 00 05 00 00 00 00 00 DM5 from Instrument Cluster #1 (23): OBD Compliance: Not intended to meet OBD II requirements (5), Active Codes: 0, Previously Active Codes: 0 09:23:48.9994 18FECE19 00 00 05 00 00 00 00 00 DM5 from Passenger-Operator Climate Control #1 (25): OBD Compliance: Not intended to meet OBD II requirements (5), Active Codes: 0, Previously Active Codes: 0 FAIL: 6.1.13.2.a Fail/warn per section A.6, Criteria for Readiness 1 Evaluation PASS: 6.1.13.2.b FAIL: 6.1.13.2.c Fail if no OBD ECU provides DM5 with readiness bits showing monitor support PASS: 6.1.13.2.d 09:23:50.2522 Destination Specific DM5 Request to Engine #1 (0) 09:23:50.2522 18EA00F9 CE FE 00 (TX) 09:23:50.2662 18FECE00 00 00 14 37 E0 1E E0 1E DM5 from Engine #1 (0): OBD Compliance: HD OBD (20), Active Codes: 0, Previously Active Codes: 0 PASS: 6.1.13.3.a FAIL: 6.1.13.4.a Fail if any difference compared to data received during global request PASS: 6.1.13.4.b End Step 1.13. DM5: Diagnostic Readiness 1: Monitor Readiness

Part 1 Test 13 [Global DM5 (request 59904 for PGN 65230 (SPNs 1218-1223))]

0653.267 000 07           18 EA FF F9 CE FE 00 (Tx)
0653.269 000 12           18 FE CE 00 00 00 14 37 E0 1E E0 1E (DM5)
Global DM5 received from SA 0
Comprehensive components support is: supported (1)
Comprehensive components status is: test complete or not supported (0)
Misfire monitoring support is: supported (1)
Misfire monitoring status is: test not complete (1)
Fuel system monitoring support is: supported (1)
Fuel system monitoring status is: test not complete (1)
Catalyst monitoring support is: not supported (0)
Catalyst monitoring status is: test complete or not supported (0)
Heated catalyst monitoring support is: not supported (0)
Heated catalyst monitoring status is: test complete or not supported (0)
Evaporative system monitoring support is: not supported (0)
Evaporative system monitoring status is: test complete or not supported (0)
Secondary air system monitoring support is: not supported (0)
Secondary air system monitoring status is: test complete or not supported (0)
A/C system refrigerant monitoring support is: not supported (0)
A/C system refrigerant monitoring status is: test complete or not supported (0)
Exhaust sensor monitoring support is: supported (1)
Exhaust sensor monitoring status is: test not complete (1)
Exhaust gas sensor heater monitoring support is: supported (1)
Exhaust gas sensor heater monitoring status is: test not complete (1)
EGR system monitoring support is: supported (1)
EGR system monitoring status is: test not complete (1)
Cold start aid system monitoring support is: not supported (0)
Cold start aid system monitoring status is: test complete or not supported (0)
Boost pressure control support is: supported (1)
Boost pressure control status is: test not complete (1)
Diesel Particulate Filter (DPF) support is: supported (1)
Diesel Particulate Filter (DPF) status is: test not complete (1)
NOx converting catalyst and/or NOx adsorber support is: supported (1)
NOx converting catalyst and/or NOx adsorber status is: test not complete (1)
NMHC converting catalyst support is: supported (1)
NMHC converting catalyst status is: test not complete (1)
0653.275 500 12           18 FE CE 03 00 00 05 00 00 00 00 00 (DM5)
WARNING: Non-OBD Module response being used
Global DM5 received from SA 3
WARNING: Non-OBD Module responded
0653.281 000 12           18 FE CE 19 00 00 05 00 00 00 00 00 (DM5)
WARNING: Non-OBD Module response being used
Global DM5 received from SA 25
WARNING: Non-OBD Module responded
0653.299 000 12           18 FE CE 17 00 00 05 00 00 00 00 00 (DM5)
WARNING: Non-OBD Module response being used
Global DM5 received from SA 23
WARNING: Non-OBD Module responded
Vehicle composite of DM5 for Comprehensive component monitoring status is 0
Vehicle composite of DM5 for Fuel System monitoring status is 1
Vehicle composite of DM5 for Misfire monitoring status is 1
Vehicle composite of DM5 for Comprehensive component monitoring support is 1
Vehicle composite of DM5 for Fuel system monitoring support is 1
Vehicle composite of DM5 for Misfire monitoring support is 1
Vehicle composite of DM5 for EGR/VVT system monitoring support is 1
Vehicle composite of DM5 for Exhaust Gas Sensor heater monitoring support is 1
Vehicle composite of DM5 for Exhaust Gas Sensor monitoring support is 1
Vehicle composite of DM5 for A/C system refrigerant monitoring support is 0
Vehicle composite of DM5 for Secondary air system monitoring support is 0
Vehicle composite of DM5 for Evaporative system monitoring support is 0
Vehicle composite of DM5 for Heated catalyst monitoring support is 0
Vehicle composite of DM5 for Catalyst monitoring support is 0
Vehicle composite of DM5 for

NMHC converting catalyst monitoring support is 1 Vehicle composite of DM5 for NOx converting catalyst and/or NOx absorber monitoring support is 1 Vehicle composite of DM5 for Diesel Particulate Filter (DPF) monitoring support is 1 Vehicle composite of DM5 for Boost pressure control system monitoring support is 1 Vehicle composite of DM5 for EGR/VVT system monitoring status is 1 Vehicle composite of DM5 for Exhaust Gas Sensor heater monitoring status is 1 Vehicle composite of DM5 for Exhaust Gas Sensor monitoring status is 1 Vehicle composite of DM5 for A/C system refrigerant monitoring status is 0 Vehicle composite of DM5 for Secondary air system monitoring status is 0 Vehicle composite of DM5 for Evaporative system monitoring status is 0 Vehicle composite of DM5 for Heated catalyst monitoring status is 0 Vehicle composite of DM5 for Catalyst monitoring status is 0 Vehicle composite of DM5 for NMHC converting catalyst monitoring status is 1 Vehicle composite of DM5 for NOx converting catalyst and/or NOx absorber monitoring status is 1 Vehicle composite of DM5 for Diesel Particulate Filter (DPF) monitoring status is 1 Vehicle composite of DM5 for Boost pressure control system monitoring status is 1

Part 1 Test 13 [DS DM5 to OBD ECUs]

0655.036 000 07           18 EA 00 F9 CE FE 00 (Tx)
0655.046 000 12           18 FE CE 00 00 00 14 37 E0 1E E0 1E (DM5)
Direct DM5 Message received from SA 0
mmschaefer commented 3 years ago

Pushed to master 12/10