Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Part 1 Step 13 should allow NA for code counts #478

Closed gumbelmj closed 3 years ago

gumbelmj commented 3 years ago
Start Step 1.13. DM5: Diagnostic Readiness 1: Monitor Readiness

10:43:19.3877 Global DM5 Request
10:43:19.2790 18EAFFF9 [3] CE FE 00 (TX)
10:43:19.2800 18FECE00 [8] 00 00 14 37 E0 1E E0 1E
DM5 from Engine #1 (0): OBD Compliance: HD OBD (20), Active Codes: 0, Previously Active Codes: 0
10:43:19.2830 18FECE55 [8] FF FF 14 00 00 00 00 00
DM5 from Diesel Particulate Filter Controller (85): OBD Compliance: HD OBD (20), Active Codes: not available, Previously Active Codes: not available
10:43:19.2835 18FECE03 [8] 00 00 05 00 00 00 00 00
DM5 from Transmission #1 (3): OBD Compliance: Not intended to meet OBD II requirements (5), Active Codes: 0, Previously Active Codes: 0
10:43:19.2885 18FECE05 [8] 00 01 00 00 00 00 00 00
DM5 from Shift Console - Primary (5): OBD Compliance: Reserved for SAE/Unknown (0), Active Codes: 0, Previously Active Codes: 1
10:43:19.3120 18FECEA7 [8] 00 01 FF 00 00 00 00 00
DM5 from Instrument Cluster #2 (167): OBD Compliance: Not available (255), Active Codes: 0, Previously Active Codes: 1

Vehicle Composite of DM5:
    A/C system refrigerant     not supported,     complete
    Boost pressure control sys     supported, not complete
    Catalyst                   not supported,     complete
    Cold start aid system      not supported,     complete
    Comprehensive component        supported,     complete
    Diesel Particulate Filter      supported, not complete
    EGR/VVT system                 supported, not complete
    Evaporative system         not supported,     complete
    Exhaust Gas Sensor             supported, not complete
    Exhaust Gas Sensor heater      supported, not complete
    Fuel System                    supported, not complete
    Heated catalyst            not supported,     complete
    Misfire                        supported, not complete
    NMHC converting catalyst       supported, not complete
    NOx catalyst/adsorber          supported, not complete
    Secondary air system       not supported,     complete

FAIL: 6.1.13.2.b - An OBD ECU reported active/previously active fault DTCs count not = 0/0
  Reported active fault count = -1
  Reported previously active fault count = -1        // FF is -1, NA is preferred per -71 //
// Still need asymmetric friendly criteria for counts … issue already assigned.  
6.1.13.2 Fail/warn criteria: 
a. Fail/warn per section A.6, Criteria for Readiness 1 Evaluation.  
b. Fail if any OBD ECU reports active/previously active fault DTCs count not = 0/0.   
c. Fail if no OBD ECU provides DM5 with readiness bits showing monitor support. 
d. Warn if any individual required monitor, except Continuous Component Monitoring (CCM) is supported by more than one OBD ECU.   
//
// Footnote 17 cites J1939-71 which says:
5.1.4. Parameter Ranges - Table 1 defines the ranges used to determine the validity of a transmitted signal. Table 2 defines the ranges used to denote the state of a discrete parameter and Table 3 defines the ranges used to denote the state of a control mode command. The values in the range "error indicator" provide a means for a module to immediately indicate that valid parametric data is not currently available due to some type of error in the sensor, sub-system, or module. The values in the range "not available" (which start with FF) provide a means for a module to transmit a message which contains a parameter that is not available or not supported in that module. 
//
mmschaefer commented 3 years ago

This is an enhancement as this was not specified in the accepted requirements.

gumbelmj commented 3 years ago

This relates to the existing issue #420