Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

Part 1 Step 14 failure for Warm-ups SCC != 0 is missing #567

Closed gumbelmj closed 3 years ago

gumbelmj commented 3 years ago

From email:

Start Step 1.14. DM26: Diagnostic readiness 3

09:30:05.6482 Global DM26 Request
09:30:05.6524 18EAFFF9 [3] B8 FD 00 (TX)
09:30:05.6582 18FDB800 [8] 00 00 05 37 40 14 E0 1E
DM26 from Engine #1 (0): Warm-ups: 5, Time Since Engine Start: 0 seconds

Vehicle Composite of DM26:
    A/C system refrigerant     not enabled,     complete
    Boost pressure control sys not enabled, not complete
    Catalyst                   not enabled,     complete
    Cold start aid system      not enabled,     complete
    Comprehensive component        enabled,     complete
    Diesel Particulate Filter      enabled, not complete
    EGR/VVT system             not enabled, not complete
    Evaporative system         not enabled,     complete
    Exhaust Gas Sensor         not enabled, not complete
    Exhaust Gas Sensor heater      enabled, not complete  
    Fuel System                    enabled, not complete 
    Heated catalyst            not enabled,     complete
    Misfire                        enabled, not complete
    NMHC converting catalyst       enabled, not complete
    NOx catalyst/adsorber      not enabled, not complete
    Secondary air system       not enabled,     complete

FAIL: 6.1.14.2.a - Engine #1 (0) response for a monitor Boost pressure control sys in DM5 is reported as supported and is reported as not enabled by DM26 response
FAIL: 6.1.14.2.a - Engine #1 (0) response for a monitor EGR/VVT system in DM5 is reported as supported and is reported as not enabled by DM26 response
FAIL: 6.1.14.2.a - Engine #1 (0) response for a monitor Exhaust Gas Sensor in DM5 is reported as supported and is reported as not enabled by DM26 response
FAIL: 6.1.14.2.a - Engine #1 (0) response for a monitor NOx catalyst/adsorber in DM5 is reported as supported and is reported as not enabled by DM26 response
FAIL: 6.1.14.2.d - Engine #1 (0) response indicates number of warm-ups since code clear is not zero
09:30:06.2620 Destination Specific DM26 Request to Engine #1 (0)
09:30:06.2677 18EA00F9 [3] B8 FD 00 (TX)
09:30:06.2773 18FDB800 [8] 00 00 05 37 40 14 E0 1E 
DM26 from Engine #1 (0): Warm-ups: 5, Time Since Engine Start: 0 seconds
09:30:06.2779 Destination Specific DM26 Request to DPF Controller (85)
09:30:06.2822 18EA55F9 [3] B8 FD 00 (TX)
09:30:06.2866 18E8FF55 [8] 01 FF FF FF FF B8 FD 00
Acknowledgment from DPF Controller (85): Response: NACK, Group Function: 255, Address Acknowledged: 255, PGN Requested: 64952
// There is a failure message missing for 6.1.14.2.d.
// 6.1.14.2 …
// d. Fail if any response indicates number of warm ups is not zero.  // This fail is missing    
// e. Fail if any response indicates time since engine start (SPN  3301) is not zero. 
// f. Fail if no OBD ECU provides DM26 
//

End Step 1.14. DM26: Diagnostic readiness 3
gumbelmj commented 3 years ago

@ericthomasswenson, the failure for warm ups SCC != 0 is present.

...
FAIL: 6.1.14.2.a - Engine #1 (0) response for a monitor NOx catalyst/adsorber in DM5 is reported as supported and is reported as not enabled by DM26 response
FAIL: 6.1.14.2.d - Engine #1 (0) response indicates number of warm-ups since code clear is not zero
09:30:06.2620 Destination Specific DM26 Request to Engine #1 (0)
...

The failure is reported using the global packets. The failure is not repeated when the value is found again in the DS packets as there is no requirement to also check the DS packets.

However if there is a difference between the global and DS responses, that failure will be noted:

6.1.14.5 Fail Criteria a. Fail if any difference compared to data received during global request.