Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

SW - Add SP 976 to Omit List #904

Closed gumbelmj closed 3 years ago

gumbelmj commented 3 years ago

From j1939-84 created by ericthomasswenson: battjt/j1939-84#899

Add SP 976 to the Omit list as shown below.

Whereas SP 976, PTO Governor State, is required in CARB regulations for optional equipment. When PTO is not supported, SP 976 is provided as NA. This breaks the assumption that supported SPs should not be received as NA (FF).

Moreover, There is no indication to disambiguate, whether the correct expectation is for Off, or NA in Part 1 and 2.

Considering this, assessment of SP 976 displays is intractable. The addition of SP 976 provides an immediate remedy.

gumbelmj commented 3 years ago

PACCAR Side-by-side Issue 3

FAIL: 6.1.26.2.a - SPN 976 was received as NOT AVAILABLE from Engine #1 (0) FAIL: 6.2.17.2.a - SPN 976 was received as NOT AVAILABLE from Engine #1 (0) Explanation – Spec/Tool Issue? Not every truck is equipped with a PTO. There must be exceptions added to this. If a truck does not have PTO then it is going to report “NOT AVAILABLE”.

This is expected to be a ubiquitous problem for all manufacturers, which cascades to additional messages as shown below.

gumbelmj commented 3 years ago

6.1.26 Data Stream Support Verification 6.1.26.1 Actions a. Create a list of expected SPNs and PGNs from the DM24 response, where the data stream support bit defined in SAE J1939-73 5.7.24 is 0. Omit the the following SPNs (588, 976, 1213, 1220, 12675, 12730, 12783, 12797) which are included in the list. Omit any remaining SPNs that map to multiple PGs. Display the completed list noting those omitted SPNs and supported SPNs as ‘broadcast’ or ‘upon request’.
b. Gather broadcast data for all SPNSPs that are supported for data stream in the OBD ECU DM24 responses. c. Gather/timestamp each parameter at least three times to be able to verify frequency of broadcast.

gumbelmj commented 3 years ago

This proposal will also resolve PACCAR side-by-side issue 4

FAIL: 6.1.26.6.a - No DS response for PGN 65265 from Engine #1 (0) FAIL: 6.2.17.6.a - No DS response for PGN 65265 from Engine #1 (0) Explanation – Spec/Tool Issue? Why is the tool sending a destination specific request for CCVS message (contains SPN 84 and SPN 976)? The CCVS message is broadcasted every 100ms

And PACCAR side-by-side issue 9

Warning: Late BAM response: 19:20:39.8578 18FEF127 [8] C4 FF FF 00 00 00 1F F0 Warning: Late BAM response: 19:20:39.8607 18FEF131 [8] F7 FF FF CF FF FF FF FF Warning: Late BAM response: 19:20:39.8645 0CFEF100 [8] F7 00 00 03 00 00 FF FF Warning: Late BAM response: 19:20:39.9566 18FEF127 [8] C4 FF FF 00 00 00 1F F0 Warning: Late BAM response: 19:20:39.9602 18FEF131 [8] F7 FF FF CF FF FF FF FF Warning: Late BAM response: 19:20:39.9645 0CFEF100 [8] F7 00 00 03 00 00 FF FF Warning: Late BAM response: 19:20:40.0567 18FEF127 [8] C4 FF FF 00 00 00 1F F0