Equipment-and-Tool-Institute / j1939-84

J1939-84 implementation for etools.org
MIT License
7 stars 6 forks source link

There should be means to continue the test when failure implants fail #958

Open ericthomasswenson opened 3 years ago

ericthomasswenson commented 3 years ago

Today’s test on a Cummins ISX could not be completed when the fault A implant failed.

In particular there is value in the general denominator test in parts 11 and 12 — skipping fault implants to get to parts 11 and 12 is expected user behavior.

ericthomasswenson commented 3 years ago

6.3.2.1 Actions a. Global DM6 [(send Request (PGNPG 59904) for PGNPG 65227 (SPNSPs 1213-1215, 3038, 1706)]). i. Repeat request for DM6 no more frequently than once per second until one or more ECUs reports a pending DTC.
ii. Time-out after every 5 minutes and ask user “‘yes/no”’ to continue if still no pending DTC; and fail if user says “'no'” and no ECU reports a pending DTC.
iii. Permit user to elect to continue test if a DM6 was not observed.

ericthomasswenson commented 3 years ago

6.4.2.1 Actions a. Global DM12 [send Request (PG 59904) for PG 65236 (SPs 1213-1215, 1706, and 3038)] to retrieve confirmed and active DTCs. i. Repeat request no more frequently than once per second until one or more ECUs reports a confirmed and active DTC.
ii. Time-out after every 5 minutes and ask user “‘yes/no”’ to continue if there is still no confirmed and active DTC; fail if user says “'no”' and no ECU reports a confirmed and active DTC. iii. Permit user to elect to continue test if a DM12 DTC was not observed.

ericthomasswenson commented 3 years ago

6.8.2.1 Actions a. Global DM12 [(send Request (PGNPG 59904) for PGNPG 65236 (SPNSPs 1213-1215, 1706, and 3038)]). b. Repeat request until one or more ECUs reports an active DTC.
i. Time-out after 5 minutes and ask user yes/no to continue if there is still no active DTC.
ii. Fail if user says “no” and no ECU reports an active DTC. iii. Permit user to elect to continue test if a DM12 DTC was not observed.

ericthomasswenson commented 2 years ago

Utility of a go on button before 100’s of DM6 or DM12 queries run was confirmed.

Proposed text not in proffer

ericthomasswenson commented 2 years ago

Add bypass to example instructions for discussion for task 8

ericthomasswenson commented 1 year ago

Reconsider best methods with multiple fault implants

battjt commented 11 months ago

Work with #1270 .