search

ErAbhishekChandani / ACFloatingTextfield

It is a subclass of UITextfield to Provide the floating label and customisations.
MIT License
125 stars 40 forks source link

Add support for iOS 13 SDK (Xcode 11) #67

Closed Axtel209 closed 5 years ago

Axtel209 commented 5 years ago

Fix placeholder text color crash on iOS 13 Change use from private API (_placeholderLabel) to attributedPlaceholder

ErAbhishekChandani commented 5 years ago

Will check This thanks

Sent from my iPhone

On 20-Sep-2019, at 10:36 AM, Giorgio Doganiero notifications@github.com wrote:

Fix placeholder text color crash on iOS 13 Change use from private API (_placeholderLabel) to attributedPlaceholder

You can view, comment on, or merge this pull request online at:

https://github.com/ErAbhishekChandani/ACFloatingTextfield/pull/67

Commit Summary

Fix placeholder color prohibited in iOS 13 SDK File Changes

M Source-Swift/ACFloatingTextfield.swift (12) Patch Links:

https://github.com/ErAbhishekChandani/ACFloatingTextfield/pull/67.patch https://github.com/ErAbhishekChandani/ACFloatingTextfield/pull/67.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

infinigent-solutions commented 5 years ago

@Axtel209 I didn't work for me, it still crashes for me

Axtel209 commented 5 years ago

@Axtel209 I didn't work for me, it still crashes for me

Does it give the same crash log?

infinigent-solutions commented 5 years ago

Yes

ErAbhishekChandani commented 5 years ago

I have checked this its working but you have added wrong placeholder color when its in selected state please review and correct this than Its good to go! Thanks

Sent from my iPhone

On 20-Sep-2019, at 10:48 AM, abhishek chandani chandani.abhishek440@gmail.com wrote:

Will check This thanks

Sent from my iPhone

On 20-Sep-2019, at 10:36 AM, Giorgio Doganiero notifications@github.com wrote:

Fix placeholder text color crash on iOS 13 Change use from private API (_placeholderLabel) to attributedPlaceholder

You can view, comment on, or merge this pull request online at:

https://github.com/ErAbhishekChandani/ACFloatingTextfield/pull/67

Commit Summary

Fix placeholder color prohibited in iOS 13 SDK File Changes

M Source-Swift/ACFloatingTextfield.swift (12) Patch Links:

https://github.com/ErAbhishekChandani/ACFloatingTextfield/pull/67.patch https://github.com/ErAbhishekChandani/ACFloatingTextfield/pull/67.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

ssantamariaArkkosoft commented 5 years ago

Hi, this error is also presented in objective c.