Closed armyf35 closed 7 months ago
As a added question. Should onApproachMediumDist and onApproachShortDist be modified to set train speed to the min of calculatedSpeed
and LocoTelem.RMMaxSpeed[locomotive]
.
Right now if you set the speed below them it will override it. For example set it to 10 MPH, once it enters range for onApproach it jumps up until the train arrives and subsequently departs again.
This is what I had suspected but didn't have time to review yesterday or today. I will review and merge tomorrow.
As a added question. Should onApproachMediumDist and onApproachShortDist be modified to set train speed to the min of
calculatedSpeed
andLocoTelem.RMMaxSpeed[locomotive]
. Right now if you set the speed below them it will override it. For example set it to 10 MPH, once it enters range for onApproach it jumps up until the train arrives and subsequently departs again.
Makes complete sense, I will add some code to implement this.
Sorry about that, meant to rename the branch didnt realize github would close the PR
This should fix #61