search

Erabior / RouteManager

Mod for Railroader the game that adds basic automation for passenger routes
12 stars 5 forks source link

V2 - onApproachShortDist - Fix overlooked code Related to Enhancment #30 and fix #61 #62

Closed armyf35 closed 7 months ago

armyf35 commented 7 months ago

This should fix #61

armyf35 commented 7 months ago

As a added question. Should onApproachMediumDist and onApproachShortDist be modified to set train speed to the min of calculatedSpeed and LocoTelem.RMMaxSpeed[locomotive]. Right now if you set the speed below them it will override it. For example set it to 10 MPH, once it enters range for onApproach it jumps up until the train arrives and subsequently departs again.

AdamC1228 commented 7 months ago

This is what I had suspected but didn't have time to review yesterday or today. I will review and merge tomorrow.

AdamC1228 commented 7 months ago

As a added question. Should onApproachMediumDist and onApproachShortDist be modified to set train speed to the min of calculatedSpeed and LocoTelem.RMMaxSpeed[locomotive]. Right now if you set the speed below them it will override it. For example set it to 10 MPH, once it enters range for onApproach it jumps up until the train arrives and subsequently departs again.

Makes complete sense, I will add some code to implement this.

armyf35 commented 7 months ago

Sorry about that, meant to rename the branch didnt realize github would close the PR