Erabior / RouteManager

Mod for Railroader the game that adds basic automation for passenger routes
12 stars 5 forks source link

V2-dev copyStationsFromLocoToCoaches - Destination unchecked on passengers cars when departing (Alarka jct) #81

Closed Voidheartd closed 7 months ago

Voidheartd commented 7 months ago

In the current V2-dev, Routemanager is unchecking the destination on passenger cars, when it goes to depart. The train is sitting at Hemingway, with passengers loaded for Alarka Jct. Whether I select just Alarka Jct, or Hemingway and Alarka Jct, as soon as the train goes to depart, Alarka Jct is unchecked (Hemingway is checked if that's selected) on the passenger cars, causing passengers to be unloaded until the train begins to move. railloader.log save.zip I let it continue on to Alarka Jct but it handled that stop correctly.

Voidheartd commented 7 months ago

I was testing this version while it was still forked and did not encounter this, so it may be the combination of starting from save and Hemingway that caused this issue as I usually do not stop there, which is why I included the save. I was able to reproduce it repeatedly from the save.

AdamC1228 commented 7 months ago

Thanks for the save. I am seeing the same and have pushed some debugging to the dev branch for this. I will investigate further.

I will also note that I have not been able to reproduce in my sandbox mode test route yet.

AdamC1228 commented 7 months ago

I believe I have identified the issue but I still need to trace it back to its source. Copy stations is getting called twice and upon second call alarka jct is missing from the relevant stations.

2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains sylva
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains dillsboro
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains wilmot
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains whittier
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains ela
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains bryson
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains hemingway
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains cochran
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains alarka
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains almond
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains nantahala
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains topton
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains rhodo
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: relevantStations contains andrews
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: selectedStationIdentifiers contains hemingway
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: selectedStationIdentifiers contains alarkajct
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: filteredStations contains hemingway 
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - DEB: Loco: NRR 2 updating car station selection
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Applying station selection to car
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Applying hemingway to car NRR 250
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Applying station selection to car
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Applying hemingway to car NRR 7950
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Applying station selection to car
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Applying hemingway to car NRR 7068
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Applying station selection to car
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Applying hemingway to car NRR 101
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Locomotive NRR 2 center of train is car NRR 7068
2024-01-10 23:42:25Z - Dispatcher_V2.0.0.4 - VER: Locomotive NRR 2 is entering into transit mode
AdamC1228 commented 7 months ago

Alpha 3 HF1 contains a fix for this.

Voidheartd commented 7 months ago

Tested in Alpha 3 HF1 and confirmed fixed.