search

Erabior / RouteManager

Mod for Railroader the game that adds basic automation for passenger routes
12 stars 5 forks source link

V1 - carInpectorUI - Failure to re-enable directional controls after disabling route mode. #84

Open Illegal-Prime opened 7 months ago

Illegal-Prime commented 7 months ago

So I have a problem where when I disable route mode and try to move the train in normal road or yard mode it prevents the train from moving in reverse. After unchecking the "Enable Route Mode" box I am locked out of selecting reverse in both Road and Yard mode.

This makes it very frustrating to wye the train around at the end of each run or put the pax cars away to use the loco for something else. The only way to fix this seems to be reloading the save. Route Manager is the only installed mod, this problem occurs in the most recent update but occurred previously as well.

I know you're working on version 2.0, but would you be able to push a hotffix for this? It would make the mod a lot more playable.

AdamC1228 commented 7 months ago

Please remember to specify the version of the mod you are on especially when the player log file is not provided.

Illegal-Prime commented 7 months ago

Player-prev.log Sorry about that, is this the log file in question? Mod version is 1.0.2.1

Erabior commented 7 months ago

I'll look into this tomorrow, I am currently away from home.

Illegal-Prime commented 7 months ago

So I have found something. The directional control works fine if you deselect all the stations after disabling route mode. It's only if the stations are selected that it breaks. It seems to have just started happening as I don't remember being able to do this previously, but this is probably a good starting point to fix the issue in whole.

armyf35 commented 7 months ago

@Erabior check this commit that is apart of v2 https://github.com/Erabior/RouteManager/commit/66847267149e1a2b0b93f8db03918b02c7d35eaf

Erabior commented 7 months ago

Oddly enough this is something that I had implemented a while ago but i guess it got changed back along the way.

Erabior commented 7 months ago

@Illegal-Prime Go ahead and try the latest Alpha build and see if that fixes the issue as the commit @armyf35 noted a previous commit should have already fixed this issue.

ewanm89 commented 7 months ago

@Illegal-Prime Go ahead and try the latest Alpha build and see if that fixes the issue as the commit @armyf35 noted a previous commit should have already fixed this issue.

Had this issue myself on 1.0.2.1, this particular problem is not an issue on V2.0.0-Alpha_3-HF1 where I was able to switch between route mode and the vanilla AI modes just fine.

ewanm89 commented 7 months ago

I also looked at the patch and the v1 code, and while if checks being removed in the patch are used, they seem to be wrapped in the altered if checks anyway. That said, not sure what the code is actually doing of how it interacts with other classes.

AdamC1228 commented 7 months ago

This issue is addressed in the v2 release of the mod.