search

EragonJ / Kaku

🎧 Kaku is a highly integrated music player supports different online platform like YouTube, SoundCloud, Vimeo and more. Available on Mac, Windows and Linux.
https://kaku.rocks
MIT License
1.07k stars 103 forks source link

History is kept in DB after clearing #542

Open mimi89999 opened 6 years ago

mimi89999 commented 6 years ago

Bug

When history is cleared in the app, history isn't removed from the db.

Steps to reproduce the bug

  1. Listen to some songs.
  2. Clear history.
  3. Open developer tools and browse the db. You will see songs that were in your history.
  4. After restarting the app they are still in the history.

What is your Kaku version?

1.9.0 and 2.0 branch

What is your OS (with version number)?

Debian GNU/Linux testing (buster)

Linux 4.18.0-2-amd64 #1 SMP Debian 4.18.10-2 (2018-11-02) x86_64

Which platform are you using to listen to music?

YouTube

Which track format are you using?

best audio

Is there any error coming from Inspector?

No

Others

None

EragonJ commented 6 years ago

so are these songs still shown on your UI ?

mimi89999 commented 6 years ago

No. They aren't. They are just left in the db.

EragonJ commented 6 years ago

if that's the case, it's not that important because this may be related to how 3rd party db lib works. Normal users won't check developer panel for this.

mimi89999 commented 6 years ago

@EragonJ I think it is important for privacy reasons. When somebody clears history, he expects them to actually be removed.

EragonJ commented 5 years ago

if that's the case, feel free to send me patch for this issue :)

mimi89999 commented 5 years ago

I think that the best way to solve this issue is to compact the db on launch.