search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

Trip.js doesn't fade out when local animation option is set to fadeIn #112

Closed bvogelzang closed 9 years ago

bvogelzang commented 9 years ago

When the local animation option is set to something like fadeIn or fadeInLeft, the trip block will not fade itself out. Instead, it will stay at full opacity until the block is completely hidden.

Simply adding a call to removeAnimation() in the 'hideTripBlock' function will fix the issue:

hideTripBlock: function() {
  this.removeAnimation(); // add this line
  this.$tripBlock.fadeOut('slow');
}

Example of the bug in action:

http://codepen.io/anon/pen/JdOBjV

EragonJ commented 9 years ago

Thanks, I'll check this before end of this week !

EragonJ commented 9 years ago

Thanks !! :)