search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

Upgrade jquery dependency #117

Closed StephaneRob closed 8 years ago

StephaneRob commented 8 years ago

Fix a more recent version of jquery with a valid bower.json. jquery-1.8.x use a deprecated component.json

bower jquery#~1.8.0         not-cached git://github.com/jquery/jquery.git#~1.8.0
bower jquery#~1.8.0            resolve git://github.com/jquery/jquery.git#~1.8.0
bower jquery#~1.8.0           download https://github.com/jquery/jquery/archive/1.8.3+1.tar.gz
bower jquery#~1.8.0            extract archive.tar.gz
bower jquery#~1.8.0         deprecated Package jquery is using the deprecated component.json
bower jquery#~1.8.0       invalid-meta jquery is missing "main" entry in bower.json
bower jquery#~1.8.0       invalid-meta jquery is missing "ignore" entry in bower.json
bower jquery#~1.8.0           resolved git://github.com/jquery/jquery.git#1.8.3+1
EragonJ commented 8 years ago

Thanks @StephaneRob , i'll update the version later.

StephaneRob commented 8 years ago

Actually the 1.8.3+1 contains a component.json (1.8.3+1 is the version downloaded when i tried to installed trip.js) The version should be at least jquery-1.10.0

There is a reason to keep an old jquery version instead of using the last jquery 1 latest stable version (1.11.3)? ("jquery" : "~1.11.3")

EragonJ commented 8 years ago

good idea, why not just point jQuery to latest ? Can you help to provide a PR for this ? big thanks +++++

StephaneRob commented 8 years ago

If we point to latest, bower will point to latest jquery2 (now 2.1.4). To avoid compatibility issues, it's maybe better to keep jquery1. If you agree, I'm going to submit a pull request like this.

EragonJ commented 8 years ago

didn't know that right now jQuery has been upgraded to 2+, yes, I mean latest stable 1.x version, thanks +++

StephaneRob commented 8 years ago

I did a pull request (#118) for this, let me know if i have to change something.