search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

Fix #117: update jquery to 1.11.x #118

Closed StephaneRob closed 8 years ago

StephaneRob commented 8 years ago

Now to contribute need to run first:

$ bower install

To install jquery and be able to run tests

EragonJ commented 8 years ago

Sorry for the late reply @StephaneRob ! For the PR, I am not quite sure why Trip.min.js was modified ? Did you change anything there ? And also, can you help to squeeze commits into one ? this would make commit history cleaner ! thanks.

StephaneRob commented 8 years ago

I'm not sure too. I didn't change anything in src dir. Maybe we used a different version a uglify and minified one is different. (dist/trip.js doesn't change only minified). If you want I can close this pull request and do it again with only one commit.

EragonJ commented 8 years ago

@StephaneRob if merging commits into one is hard, i can help ! If you can't do that, I can still merge the PR directly by the way. Just tell me your thought about this :)

StephaneRob commented 8 years ago

@EragonJ I'm going to close this pull request and will submit a new one with only one commit. Let you know if need help. Thanks.

EragonJ commented 8 years ago

ok thanks man ! I'll wait for you following PR, I really appreciate it !! big thanks again :+1: