search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

Optimization on CSS #129

Closed kafeltz closed 8 years ago

kafeltz commented 8 years ago

I think it would be nice to have only the used animation in the trip.css not all of them. My css file have 30kb and could have something around 6.3kb. In my case, and I'm 100% sure I only want fadeIn animation for example.

And I think it would be nicer to make animate.css optional, because other plugins use them too, and the code becomes replicated over the over again. Of course this is the programmer responsibility when using grunt-task.

EragonJ commented 8 years ago

:+1: I did have the same idea before but forgot to implement that and you just reminded me of this. I'll add a PR for this part ! thanks

EragonJ commented 8 years ago

Right now we do support trip.nodep.css & trip.nodep.min.css for this use. Hope you like it :)

kafeltz commented 8 years ago

Today I saw this file and I thought I asked you something silly that is already done. lol, you are really really quick!

And yes, i like it.

EragonJ commented 8 years ago

Well, it's not that silly to be honest. It's really a use case that people may need (including me), in my thought, there should be no any dependency in Trip.js in the future (no matter jquery part or css part). No matter how, users now can choose which file to include and these files are generated dynamically with no extra efforts, so it's fine :)