search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

Trip.min.js doesn't work #137

Closed EragonJ closed 8 years ago

EragonJ commented 8 years ago

Just got a mail from Timo saying that Trip.min.js 3.1.2 doesn't work with no reason and I can reproduce that in my side. Need to fix that and bump to 3.1.3.

kafeltz commented 8 years ago

Uglify issue?

EragonJ commented 8 years ago

I think so ! Because Trip.js works fine

avdaredevil commented 8 years ago

Yes, I'm getting: Uncaught ReferenceError: Trip is not defined All my demo functionality broke, I had to switch to the unminified version.

EragonJ commented 8 years ago

sorry @avdaredevil , I should bump Trip.js to 3.2.0 instead because this is a big change. I'll dig into the bug and fix it up soon. Sorry for the inconvenience again xD

EragonJ commented 8 years ago

any help is welcome if you are wiling to dig into the bug, this should be some configurations bug in webpack.

EragonJ commented 8 years ago

Hi guys, this should be fixed in 3.1.3 ! Please give it a try when you guys have time and sorry again for the inconvenience ! I should bump to 3.2.0 instead instead of breaking your working environments ! xD

avdaredevil commented 8 years ago

Thanks! It works

EragonJ commented 8 years ago

:+1: