search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

Background blinks in new version #146

Closed kafeltz closed 8 years ago

kafeltz commented 8 years ago

I updated from 3.1.0 to 3.1.5 and now I experience the black-background when trip is with expose: true. I tested on online demo and I see this same behavior.

In 3.1.0 after each transition the black screen continues black normally. In 3.1.5 each next-step causes fadeIn->fadeOut->fadeIn effect, which is not desired.

Was this intended? I don't know.

I know the code which do that is: this.$overlay.fadeOut(); The old one is: this.$overlay.hide(); Which I prefer.

Fadeout effect would be suitable when the last trip is triggered or user cancelled manually.

Maybe, this behavior effect should the customized by global config. Any thoughts?

EragonJ commented 8 years ago

@kafeltz what you mean In 3.1.5 each next-step causes fadeIn->fadeOut->fadeIn effect, which is not desired. ?

I checked the online example but I can't get what's wrong there. Can you drop an example code on jsfiddle here ?

Big thanks :)

kafeltz commented 8 years ago

@EragonJ Yes, hold on.

kafeltz commented 8 years ago

With fadeIn/fadeOut effect in v3.1.5: https://jsfiddle.net/shalanga/wsc6rz8h/

Without fadeInt/fadeOut effect in v3.1.0 https://jsfiddle.net/shalanga/wsc6rz8h/1/

This fade's effect is not good for me, I'd like to keep it black all the time when switching steps!

Thoughts?

EragonJ commented 8 years ago

@kafeltz you mean if there are few following exposed steps defined in sequence, the exposed background should not be fadeOut then fadeIn, right ? If so, I think your concern might be reasonable. Maybe we need to check next step's expose property before deciding to hide or not.

Or you mean something else ?

kafeltz commented 8 years ago

@EragonJ Yes! That's it!

We could check, but still we are bound in this effect. I still wish no effect. Just show/hide instantly.

Maybe this could be solve only changing the effect.

EragonJ commented 8 years ago

I think the default effect can be fadeIn / fadeOut while devs can override with their own with CSS, so I think I'll introduce one more CSS class here.

kafeltz commented 8 years ago

@EragonJ yeah, could be a nice solution.

EragonJ commented 8 years ago

@kafeltz if you have some spare time and willing to read codes, feel free to provide patches if you want xD I am spammed with bugs and issues here. (It would be nice to have some contributors to make it better !!!)

louis49 commented 8 years ago

+1

R0binT commented 8 years ago

+1

maevaD commented 8 years ago

+1

teddymeksavanh commented 8 years ago

+1

AdrienDesola commented 8 years ago

+1

kafeltz commented 8 years ago

@EragonJ I will take a look on this issue. Time for no more procrastination.

EragonJ commented 8 years ago

lol big thanks ~~