search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

update to jQuery 2.2 #153

Closed dustfeather closed 8 years ago

dustfeather commented 8 years ago

Hi, Can someone please update the jQuery required version to 2.2.* ? Or at least make it jquery#>=1.11.3 instead of jquery#~1.11.3 Thanks.

kafeltz commented 8 years ago

= 1.11.3 or ~1.11.3 would be the same thing But would be nice to update jQuery version since 2.x works pretty good

I'm using here v2.1.4 and it's working fine. But i'm not using all features of trip.js, so, it could happen something unexpected.

EragonJ commented 8 years ago

Is there any special reason to update jQuery 2.x ? I didn't follow recent updates and know nothing about that, can you guys share some info about that ?

But no matter how, if you want to use latest jQuery, why not just assign that in your bower.json or package.json ? The tool will help you to install latest version you assigned, right ?

kafeltz commented 8 years ago

@EragonJ I agree

EragonJ commented 8 years ago

@dustfeather , any idea ?

kafeltz commented 8 years ago

I see no need to update. As I add jQuery individually by hand this is not a problem to me.

EragonJ commented 8 years ago

Cool thanks :)

EragonJ commented 8 years ago

@dailyherold my original thought is that Trip.js can support version >= 1.x and that's why in package.json, its version is 1.x. So if you want to use latest version, feel free to add jQuery dependency into your package.json and npm will automatically figure that out for you !

dustfeather commented 8 years ago

My bower.json looks kind of like this:

"dependencies": {
    "jquery": "2.2.2",
    "jquery-ui": "^1.11.4",
    "bootstrap": "~3.3",
    "Trip.js": "trip.js#^3.1.5"
  }

@EragonJ And out of all the packages I need, trip.js is the only reason I get stuck with jQuery 1.x instead of 2.x http://stackoverflow.com/questions/18145094/what-functionality-will-i-lose-downgrading-jquery-from-2-0-to-1-10 "For newer browsers, you shouldn't see any difference (except possibly a faster jQuery because of its smaller size.)" ... I like having faster applications :)