search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

fixed #146, show expose based on the prev step #165

Closed HevLfreis closed 7 years ago

EragonJ commented 7 years ago

@HevLfreis thanks for the help ! I slightly changed your changes but still keep your credit in codebase ! Thanks for the help :)

HevLfreis commented 7 years ago

@EragonJ hi, your change will result in only the first elem being highlighted during a trip with expose. The problem is that the overlay hide every time you make a step, so i send a false flag to the hideExpose() func to tell the func not to hide the overlay, we already have one. You can test my code and your new code on your highlight demo. With your new version, the run demo button will never be highlighted.

EragonJ commented 7 years ago

@HevLfreis good point ! I didn't notice that, let me fix that, thanks !!

EragonJ commented 7 years ago

fixed :)