search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

enableAnimation should be allowed to be set (or unset) on a per-trip basis (local setting) #172

Closed 71FIL closed 8 years ago

71FIL commented 8 years ago

I found myself in need of not animating a few trips while most others were. I actually called the option disableAnimation on those specific trips as I had no need to only animate a few trips.

My use case was as follows: I wanted a trip to be shown with some content without navigation for a few seconds and then be apparently expanded with extra content and navigation. Having animation turned on caused the second "expansion" trip to be shown with movement which broke the illusion of having a single trip which was expanding after a few seconds.

An orthogonal definition of both local and global enableAnimation would allow more scenarios. I could imagine someone wanting animation only on a subset of strategic trips.

EragonJ commented 8 years ago

cool, I already left comments on PR !

EragonJ commented 8 years ago

thanks and merged !