EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

preventDefault interfering with application #180

Open 71FIL opened 7 years ago

71FIL commented 7 years ago

I wonder why preventDefault() is being called in event handlers, especially when a nextClickSelector is defined. Preventing the default will interfere with applications.

If, for example, the nextClickSelector is a link, preventing the default will not follow the link thus the application will not work as it would if a trip was not underway.

The same question goes for preventDefault() on the trip block navigation buttons although those are specific to Trip and are unlikely to have an impact outside of trip.