search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

Change $root to html and only use visible element #198

Closed phroggar closed 5 years ago

phroggar commented 5 years ago

By changing $root from body to html the scrolling is fixed ( see https://stackoverflow.com/questions/46071588/chrome-61-jquery-scrolling-not-working-anymore ). Affects #190 and #195

If the sel option is used an leads to a hidden element, the positioning will not work. As a quickfix you can make sure that only visible elements are selected by adding :visible to the CSS selector. Affects #168

Please note that these changes have not been tested on various browsers and the ':visible' change is a bit dirty. But the changes worked for me so far and i wanted them documented for everyone else.

EragonJ commented 5 years ago

Thanks for help, but it's weird to use :visible selector here because I think it's dev's main job to handle this edge case not by Trip.js. I already merged a patch to fix html > body issue, so close this one!