search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 111 forks source link

Object doesn't support this property or method #39

Closed waldobuck closed 10 years ago

waldobuck commented 10 years ago

Awesome plugin!

However, while it works fine with Chrome, Firefox, and IE9, it does not work with IE8 and gives an error “Object doesn't support this property or method” and prevents the plugin from running properly.

While I realize GitHub does not support IE8 and below, is there a workaround or fix for this so users with IE8 can benefit from this plugin?

Thanks for your help.

Waldo Buck www.CoolZips.com

EragonJ commented 10 years ago

Thanks for reporting this bug, i would give it a look later and would comment back when I find the root cause!

@waldobuck ++

EragonJ commented 10 years ago

Bad news, my vm is broken and can't test it on IE ... I would come back when it's recovered !

EragonJ commented 10 years ago

@waldobuck i checked it in IE8, well basically all related errors are coming from outside of Trip.js. So if you use the source code in your website directly, it would be able to run. But sadly, because I use a lot of modern browsers' features like pseudo-elemnet selectors and some CSS3 animations, UI would not work nicely and you may need to put some tweaks for it.

And by the way, IE 6/7/8 is not my target browser, so I have no plans for Trip.js to support it. Maybe it's time to target your audiences with IE9+ !! :punch:

EragonJ commented 10 years ago

If you are willing to provide patches is welcome by the way ! :P

waldobuck commented 10 years ago

Thanks for your help and digging into the problem. Unfortunately our company has not upgraded its current standard of IE8 for intranet use.

EragonJ commented 10 years ago

no problem @waldobuck ! If your tool is for intranet use, then I think it is more possible to drop the support of old-fashioned browsers. Hope your company can think twice more about this and make your tool better to use for the other coworkers ! :facepunch: