search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 109 forks source link

onTripEnd never called when going backwards #75

Closed tsouvarev closed 10 years ago

tsouvarev commented 10 years ago

prev method missing call of onTripEnd. Simple copy-paste from next method solves the problem

Fire-Brand commented 10 years ago

It seems it doesn't call onTripStart as well...

EragonJ commented 10 years ago

From my design, because the trip didn't finish successfully, so onTripEnd will not be called.

EragonJ commented 10 years ago

It seems it doesn't call onTripStart as well...

prev() did call run(), and run() did call onTripStart() if you check from the codebase :)

EragonJ commented 10 years ago

@Fire-Brand , @tsouvarev hope this clarify something !

tsouvarev commented 10 years ago

From my design, because the trip didn't finish successfully, so onTripEnd will not be called.

Why do you think that trip didn't finish successfully? prev is called when you click 'go backwards' button, so it's a normal flow

EragonJ commented 10 years ago

We can try to fix this in next version if possible !