search

EragonJ / Trip.js

🚀 Trip.js is a plugin that can help you customize a tutorial trip easily with more flexibilities.
https://eragonj.github.io/Trip.js/
MIT License
793 stars 109 forks source link

allow to configure the placement of the overlay #76

Closed fernandezpablo85 closed 10 years ago

fernandezpablo85 commented 10 years ago

Due to stacking frames[1], sometimes placing the overlay in the <body> just doesn't work (because the element you're trying to highlight is in a higher stacking frame).

This happens a lot if you use, say bootstrap templates, that contains many relative positioned elements. This 2-liner let's you specify where to put the overlay so you can overcome this issue.

[1] http://philipwalton.com/articles/what-no-one-told-you-about-z-index/

EragonJ commented 10 years ago

@fernandezpablo85

I think this change make sense and can you use grunt build to help me build the minified version at the same time ? Thanks !!

fernandezpablo85 commented 10 years ago

@EragonJ you still need me to run grunt? I'd be happy to

EragonJ commented 10 years ago

@fernandezpablo85 I thought you are missing, so I just did that for you haha

Thanks for your help :)

fernandezpablo85 commented 10 years ago

Thank you, looking forward to the next relase! Great lib BTW

On Thu, Sep 25, 2014 at 2:34 PM, EragonJ notifications@github.com wrote:

@fernandezpablo85 https://github.com/fernandezpablo85 I thought you are missing, so I just did that for you haha

Thanks for your help :)

— Reply to this email directly or view it on GitHub https://github.com/EragonJ/Trip.js/pull/76#issuecomment-56854506.