Remove String class dependency on (types in) WProgram.h

Eralt / arduino

Automatically exported from code.google.com/p/arduino

0 stars 0 forks source link

Remove String class dependency on (types in) WProgram.h #310

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

new String library causes errors in compile for LiquidCrystal library.

SOLUTION:  Add 

#include "WProgram.h"   

in LiquidCrystal.h line 5, before the inclusion of Print.h

Original issue reported on code.google.com by tom.i...@gmail.com on 31 Jul 2010 at 10:21

GoogleCodeExporter commented 9 years ago

Original comment by dmel...@gmail.com on 31 Jul 2010 at 10:37

Added labels: Component-Core, Milestone-0019

GoogleCodeExporter commented 9 years ago

Original comment by dmel...@gmail.com on 3 Aug 2010 at 12:55

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Fixed for the default libraries, Yes!

But there are probably user-libs that fall into the same trap.

It happend to me with a library for a lcd-class with SPI-interface which is 
derived from class Print. 
http://code.google.com/p/doglcd/

If there is no other way to fix this, there should be a warning in the release 
notes about this, so lib-authors can update their code.

Original comment by e.fa...@wayoda.org on 3 Aug 2010 at 7:50

GoogleCodeExporter commented 9 years ago

Original comment by dmel...@gmail.com on 5 Aug 2010 at 3:19

Changed title: Remove String class dependency on (types in) WProgram.h
Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Okay, I think I fixed this with r1037.

Original comment by dmel...@gmail.com on 6 Aug 2010 at 1:24

Changed state: Fixed