search

EranGrin / vue-web-component-wrapper

vue3 - web component wrapper plugin
https://erangrin.github.io/vue-web-component-wrapper/
60 stars 8 forks source link

shadowRoot prop casing mis-match in DefineCustomElementConfig type definition #25

Closed OllyNicholass closed 4 months ago

OllyNicholass commented 4 months ago

https://github.com/EranGrin/vue-web-component-wrapper/blob/3063fa4ca8f36e3146b16fd5dcfcd4baf3ac9a7d/package/types.d.ts#L24

https://github.com/EranGrin/vue-web-component-wrapper/blob/3063fa4ca8f36e3146b16fd5dcfcd4baf3ac9a7d/package/src/api-custom-element.ts#L48

Causes errors on build using typescript:

error TS2345: Argument of type '{ shadowRoot: boolean; }' is not assignable to parameter of type 'defineCustomElementSFCOptions'.
  Object literal may only specify known properties, but 'shadowRoot' does not exist in type 'defineCustomElementSFCOptions'. Did you mean to write 'ShadowRoot'?

10 export const NavBarLinkGroupCE = defineCustomElementSFC(NavBarLinkGroupVue as any, { shadowRoot: true });
EranGrin commented 4 months ago

Oh...wow, I'll push a bugfix version Thank you

EranGrin commented 4 months ago

Closing the ticket as changes are part of the latest version