EranGrin / vue-web-component-wrapper

vue3 - web component wrapper plugin
https://erangrin.github.io/vue-web-component-wrapper/
59 stars 7 forks source link

Vite 4 + Vue 3.3 + TS 5 support #3

Closed mrcego closed 1 year ago

mrcego commented 1 year ago

Based in #2, I was working in Vite 4 + TypeScript 5 + Vue 3.3 support ensuring correct solution at demo-app-vite.

Please, don't merge until checklist is completed.

Checklist

mrcego commented 1 year ago

@EranGrin I have marked it as ready to review to listen feedbacks and thoughts from you about current work. Regards.

mrcego commented 1 year ago

Thank you for the PR I left a few comments, but one major aspect I didn't check or mentioned is the vite production build.

Yeah, we need to test this in detail. Even if the build config from this PR works as expected, it would be good if you check it more intense.

EranGrin commented 1 year ago

Merge PR into feature branch vite-support