EranOfek / AstroPack

Astronomy & Astrophysics Software Pacakge
Other
17 stars 4 forks source link

Error in pipeline.last.forcedPhotAll #202

Closed YarinMS closed 1 year ago

YarinMS commented 1 year ago

While trying to apply forced photometry on processed images, the following error is encountered :

image

We see that in forcedPhot 'Moving' = moving but there is no documentation that explains how to control this argument using focedPhotAll.

The first thing comes to mind is maybe the coordinates given as an argument to the function [ra1 , dec1] are close to the subframe boundaries. But, this error is consistent with different coordinates from different fields. Providing two examples from the coordinates we tried to implement forcedPhotAll for :

pwd = '/last02e/data1/archive/LAST.01.02.01/2023/07/20/proc/' :

Object = 'LAST*_253+02_*022_sci_proc_Image_*.fits'

ra1 = 255.111679 ; dec1 = 3.6005

image

Where it doesn't seem like the target itself could be outside of the image boundaries, ( maybe its the reference sources ? )

Second example :

Object = 'LAST*_261+64_*018_sci_proc_Image_*.fits'

ra1 = 264.12176 ; dec1 = 66.73127

image

It doesn't look like this error arise due to the location of the target coordinates.

EranOfek commented 1 year ago
  1. The Moving argument is explained in the help of imProc.sources.forcedPhot and in the wiki pages.
  2. I am aware of this bug, but the fix is not straightforward. Meanwhile, I increased the default of MinEdgeDist to 20. Not sure it will solve the problem, but let me know.

On Sun, Jul 30, 2023 at 12:46 AM YarinMS @.***> wrote:

While trying to apply forced photometry on processed images, the following error is encountered : [image: image] https://user-images.githubusercontent.com/118757319/257012162-a933cbf6-a708-4bdf-bcad-9b572779a669.png We see that in forcedPhot 'Moving' = moving but there is no documentation that explains how to control this argument using focedPhotAll.

The first thing comes to mind is maybe the coordinates given as an argument to the function [ra1 , dec1] are close to the subframe boundaries. But, this error is consistent with different coordinates from different fields. Providing two examples from the coordinates we tried to implement forcedPhotAll for :

pwd = '/last02e/data1/archive/LAST.01.02.01/2023/07/20/proc/' :

Object = 'LAST253+02022_sci_procImage*.fits'

ra1 = 255.111679 ; dec1 = 3.6005 [image: image] https://user-images.githubusercontent.com/118757319/257012667-b164a61e-abf0-420e-8db3-38231e781e17.png

Where it doesn't seem like the target itself could be outside of the image boundaries, ( maybe its the reference sources ? )

Second example :

Object = 'LAST261+64018_sci_procImage*.fits'

ra1 = 264.12176 ; dec1 = 66.73127 [image: image] https://user-images.githubusercontent.com/118757319/257013249-58eed453-8c4b-4116-88c6-78afa5e3c179.png

It doesn't look like this error arise due to the location of the target coordinates.

— Reply to this email directly, view it on GitHub https://github.com/EranOfek/AstroPack/issues/202, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJUQ4K36JDOWS2X4DTIGUDXSWAB3ANCNFSM6AAAAAA24XV3WI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

YarinMS commented 1 year ago
  1. Thanks for the clarification
  2. git pulled on last02e to try again yield the same error. I will try it on another set of data on last04w, just to be sure.
EranOfek commented 1 year ago

in imProc.sources.forcedPhot line 400 - put a breakpoint and run again. please save Obj, XY, Fun as a mat file and send it to me. when sending mat files, remember to send it to my gmail (WIS mail doesn't like mat files...)

YarinMS commented 1 year ago

apparently, when saving proc images for forced photometry, we should save the Mask file as well...

(pipeline runs again in last02, i'll update if it solves the problem)

YarinMS commented 1 year ago

Together with a MASK file, the function works great. Should we reverse the change in MinEdgeDist ?.

EranOfek commented 1 year ago

Not critical - 20 pix is good.

On Fri, Aug 4, 2023 at 8:30 AM YarinMS @.***> wrote:

Together with a MASK file, the function works great. Should we reverse the change in MinEdgeDist ?.

— Reply to this email directly, view it on GitHub https://github.com/EranOfek/AstroPack/issues/202#issuecomment-1665034657, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJUQ4P5BLBBGV36J2NRAQDXTSCHXANCNFSM6AAAAAA24XV3WI . You are receiving this because you commented.Message ID: @.***>