search

EranOfek / AstroPack

Astronomy & Astrophysics Software Pacakge
Other
19 stars 4 forks source link

ephem - offset bug #276

Closed EranOfek closed 1 year ago

EranOfek commented 1 year ago

When comparing the result of ephem (using kepler equation or integration) to JPL horizons, small offsets of tens of arcsec are seen. This was tested at the epoch of the orbital elements so this is not due to propagation errors. I have seen this problem before, and I thought it was solved.

EranOfek commented 1 year ago

One bug was found - in celestia.kepler.celestial.Kepler.kepler_elliptic the calculation of the period was wrong (I likely introduced this bug, a year ago). Now corrected. Continue debuging and adding tests to unitTest

EranOfek commented 1 year ago

Problem solved. Indded it was due to the bug introduced into kepler_elliptic. Several new functions were added to celestial.OrbitalEl and celestial.SolarSys and celestial.INPOP.