EranOfek / AstroPack

Astronomy & Astrophysics Software Pacakge
Other
19 stars 4 forks source link

SN_? source catalog column employed by imProc.calib.photometricZP #509

Open agioffe opened 3 weeks ago

agioffe commented 3 weeks ago

By default imProc.calib.photometricZP relies on SN_2 column (previously it was SN_3) in the source catalog. Once we use imProc.sources.findMeasureSources with an empirically measured PSF rather then a set of Gaussians (can be the case for multi-iteration PSF photometry), it provides only SN_1, but neither SN_2 nor SN_3, which leads to a crash of imProc.calib.photometricZP.

So the question is whether a) to change the default behavior of imProc.calib.photometricZP to use SN_1 or SN (which is added to the source table any time we use PSF photometry, either single- or multi-iteration) instead of SN_2 or SN_3 or b) to change the Args.photometricZPArgs{:} argument within pipeline.generic.singleRaw2proc if multi-iteration PSF photometry with empirical PSF search is employed therein.

@EranOfek , what do you think?

EranOfek commented 3 weeks ago

In the new version (mextractor) we should do the following: after the PSF fitting: use X and Y to calculate SN_DELTA - i.e., FLUX_AT_X_Y/ANNULUS_STD

In addition, at the best fit position of each source we should fit (only the flux) using an extended version of the PSF - i.e., the PSF convolved with a predefined exponential function (extended sources). This will be called: SN_EXT1 and maybe SN_EXT2

On Wed, Oct 30, 2024 at 1:49 PM Alexander Krassilchtchikov < @.***> wrote:

By default imProc.calib.photometricZP relies on SN_2 column (previously it was SN_3) in the source catalog. Once we use imProc.sources.findMeasureSources with an empirically measured PSF rather then a set of Gaussians (can be the case for multi-iteration PSF photometry), it provides only SN_1, but neither SN_2 nor SN_3, which leads to a crash of imProc.calib.photometricZP.

So the question is whether a) to change the default behavior of imProc.calib.photometricZP to use SN_1 or SN (which is added to the source table any time we use PSF photometry, either single- or multi-iteration) instead of SN_2 or SN_3 or b) to change the Args.photometricZPArgs{:} argument within pipeline.generic.singleRaw2proc if multi-iteration PSF photometry with empirical PSF search is employed therein.

@EranOfek https://github.com/EranOfek , what do you think?

— Reply to this email directly, view it on GitHub https://github.com/EranOfek/AstroPack/issues/509, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJUQ4JGY2M2LVFE6VEIBO3Z6DBWLAVCNFSM6AAAAABQ35Q4YGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGYZDGOBUGAZDQMQ . You are receiving this because you were mentioned.Message ID: @.***>

EastEriq commented 3 weeks ago

Does this affect my work in https://github.com/EastEriq/PTF/?

EranOfek commented 3 weeks ago

no - we are discussing a new function.

On Wed, Oct 30, 2024 at 4:53 PM EastEriq @.***> wrote:

Does this affect my work in https://github.com/EastEriq/PTF/?

— Reply to this email directly, view it on GitHub https://github.com/EranOfek/AstroPack/issues/509#issuecomment-2447416697, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJUQ4LPWFETHALJCXCZPITZ6DXH3AVCNFSM6AAAAABQ35Q4YGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXGQYTMNRZG4 . You are receiving this because you were mentioned.Message ID: @.***>