search

EranOfek / AstroPack

Astronomy & Astrophysics Software Pacakge
Other
19 stars 4 forks source link

imProc.db.generateImageID: old LAST coadds lead to error due to lack of some keywords #523

Open agioffe opened 2 hours ago

agioffe commented 2 hours ago

Some of the old LAST coadds, e.g. /mnt/marvin/LAST.01.01.01/2023/04/24/proc/185438v0/coaddIma*fits, do not contain neither "NODENUMB" nor "MOUNTNUM" keywords in the header, which leads to an error in imProc.db.generateImageID if it is run with 'ErrorOnNaN' = true (default). Hence, there is a question how to correct it without influencing all the images during a bulk processing.

EastEriq commented 2 hours ago

I think that these keys were added at some point in the raw images, with minimal research I could find out exactly with which commit of LAST_OCS if that is relevant. Anyway, the easiest solution seem to me to set NODENUMB=1 and derive MOUNTNUM from the file location, i.e. /LAST.01.01.01/

EranOfek commented 2 hours ago

A function that correct a user defined set of keywords will be useful - add it to the FITS class.

On Mon, Nov 18, 2024 at 1:50 PM Alexander Krassilchtchikov < @.***> wrote:

Some of the old LAST coadds, e.g. /mnt/marvin/LAST.01.01.01/2023/04/24/proc/185438v0/coaddImafits, do not contain neither "NODENUMB" nor "MOUNTNUM" keywords in the header, which leads to an error in imProc.db.generateImageID* if it is run with 'ErrorOnNaN' = true (default). Hence, there is a question how to correct it without influencing all the images during a bulk processing.

— Reply to this email directly, view it on GitHub https://github.com/EranOfek/AstroPack/issues/523, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJUQ4KZI6P66NF5BSNSSK32BHIBJAVCNFSM6AAAAABR7O47E2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3DQMZQGA4DENI . You are receiving this because you were assigned.Message ID: @.***>

agioffe commented 2 hours ago

OK, added it to my plan.