search

EranOfek / MAAT

37 stars 13 forks source link

Bugfix branch #12

Closed vancky closed 5 years ago

vancky commented 5 years ago

11

EranOfek commented 5 years ago

Hi Fan,

1. re: astrometry.m - and introducing InPar.RefCatName This change is not what I had in mind. What I was planning is that if you provide an external catalog - you will provide a function handle into RefCat and this function handle will return the catalog.

In order to fix it I added to astrometry.m something like:

if isa(InPar.RefCat,'function_handle') RefCat = InPar.RefCat; else...

Therefore, I can't merge your current change, but I pushed the new version.

  1. re: ClassWCS and fsolve. This is probably good, as I also have problems here sometime. However, can you please re-write this in a different way - specifically: keep the two methods in the code and add a parameter DefV.SolverType = 'fsolve'; % 'fsolve' | 'olditer'

and then in the code: switch lower(InPar.SolverType) case 'fsolve' your code... case 'olditer' my code... end

in this case we can keep both options. I will appreciate it if you can implement this change.

  1. re: deflat - I add this, but called it InPar.Verbose (to be consistent)

Thanks!!! Eran

On Fri, Mar 29, 2019 at 4:11 PM vancky notifications@github.com wrote:

11 https://github.com/EranOfek/MAAT/issues/11

You can view, comment on, or merge this pull request online at:

https://github.com/EranOfek/MAAT/pull/12 Commit Summary

  • bug fix for external catalog , crash when call switch lower(InPar.RefCat)
  • add deflat logging information, default is false
  • small spelling mistake
  • bug fix and improvement for inverse_tpv, use matlab fsolve to find root

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/EranOfek/MAAT/pull/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AFNIcdF9rx5jNcHY7ZX4PNytyod__9I8ks5vbhEBgaJpZM4cSWyY .