[FEATURE] automated-jb2a-animations compatibility

[zautos]

I would like it to work with automated-jb2a-animations [https://github.com/otigon/automated-jb2a-animations]. To add a lot of visual flair to the game.

Make compatibility code and then make a pull request on the module. https://github.com/otigon/automated-jb2a-animations/issues/194

I don't think there are any alternative modules that can do the same thing.

[Eranziel]

I'm leaving this open, but it's pretty far down my priority list. Most likely someone else will need to work on this compatibility if it's going to happen, I do not expect to have time to pursue it.

[Eranziel]

This is implemented by the Lancer Weapon FX module, so closing this issue.

[MrVauxs]

This is implemented by the Lancer Weapon FX module, so closing this issue.

Lancer Weapon FX module is pretty much a Compendium of macros you have to enable manually, it does not add automated animations functionality (i.e. you attack from any place on your sheet, and an animation happens along with the roll; you need to exclusively create a macro to do the animations and roll attacks with that macro or else animations don't happen).

I would argue keeping this issue open, as the feature is not implemented by that module. It provides animations, sure, but not the actual feature request.

[MrVauxs]

By the way, the way to implement this is to pass down the entity that caused the animation in the chat message.

I.e. if you are rolling an attack roll with a weapon, a reference to that weapon on the pilots sheet is passed down to chat message data.

Edit: This looks like a fundamental change mentioned in #429, which I think gives even more reason to keep this open, to not have people wonder why there are no real automated animations.

[Eranziel]

We do pass the actor and item IDs down to the chat message, and the latest version of Lancer Weapon FX will automatically use those to identify the weapon type and play an animation. The module currently supports all weapons (player and NPC) from official Massif sources.

[Eranziel]

That seems to fulfill the intent of the issue to me, am I missing something?

While Lancer Weapon FX doesn't currently support non-official weapons automatically, the devs have been discussing ways to support third party and custom items.

[MrVauxs]

If that's the case I think then the only thing left is to let @Otigon know. If the LWFX module also starts doing automated animations, then sure, this would be fulfilled.

[dodgepong]

The latest version of LWFX supports zero-config automated animations for official Massif content as of a couple versions ago. If it's not working for you, I recommend reporting it on the LWFX repo.

[MrVauxs]

I haven't used it in a while, thus my surprise, but just looked at the code and I see certain... similarities to other modules hahah Kudos!