Eranziel / foundryvtt-lancer

A Foundry VTT game system for LANCER RPG.
GNU General Public License v3.0
105 stars 63 forks source link

[BUG] LCP importer does not import Statuses, Sitreps, Environments, Skills, Quirks, Reserves #431

Open phenomen opened 2 years ago

phenomen commented 2 years ago

Describe the bug When you import LCP with custom data for Statuses, Sitreps, Environments, Skills, Quirks, or Reserves, it does not import anything and compendium is empty.

To Reproduce Steps to reproduce the behavior:

  1. Create a LCP with custom data (or just repackage lancer-data)
  2. Import LCP into Foundry
  3. Check Compendium for imported content

Expected behavior All content from LCP should be in compendium.

Platform:

Discord contact info Phenomen#1337

Eranziel commented 3 months ago

Note that sitreps, environments, and quirks are no longer item types in 2.0, so we expect that they will be ignored currently. The others may or may not import correctly, I haven't specifically tested them.

nedredmond commented 3 months ago

@Eranziel It doesn't look like I can assign myself to this issue. Would you do the honors?

nedredmond commented 4 days ago

Looking for good test data-- tried The Long Rim's demo LCP. It looks like downtime actions and weapons are also not being imported. Image Image

Eranziel commented 4 days ago

Long Rim and Field Guide to the Karrakin Trade Baronies would be good examples. LR has a downtime action (you're right, looks like we aren't importing those), and KTB includes the Intangible status.

Weapons are being imported properly, the LCP importer lists them as "Mech weapons".

nedredmond commented 12 hours ago

Thanks for pointing that out. I'm adding vitest to help me figure out what's happening at each level-- I didn't see any other test runner. Hope that's alright!