search

Eranziel / foundryvtt-lancer

A Foundry VTT game system for LANCER RPG.
GNU General Public License v3.0
109 stars 64 forks source link

[BUG] Overshield has a max of 14 #639

Closed CesarShogun closed 6 months ago

CesarShogun commented 6 months ago

Describe the bug Overshield has a default maximum of 14. This makes the overshield bar to appear, and I don't want that. I can't remove that max.

To Reproduce Steps to reproduce the behavior:

  1. Drag any functional PC or NPC token on a scene
  2. Right click on that token
  3. Click on the cog icon
  4. Click on "Resources"
  5. Click on "Bar 1 Attribute" and select "overshield"
  6. See that on "Bar 1 Data" appears "0/14"

Expected behavior The max values makes the overshield bar appear, but I don't want that. I'm using Bar Brawl.

Screenshots overshield max

overshield max bar brawl This is with Bar Brawl

Platform (please complete the following information):

Discord contact info I'm @Zexarius in the Pilot NET discord

Eranziel commented 6 months ago

This is tricky, it's not easy (perhaps even impossible?) to support both allowing overshield to be a bar and allowing it to be used as a single value with no bar.

I'll think on it; personally I prefer having overshield present as a bar, but I'm open to being in the minority here.

CesarShogun commented 6 months ago

I wasn't sure if it was a feature or a bug. I've found a workaround, so don't change something you don't want to. Your code, your rules ;)

msprijatelj commented 6 months ago

@CesarShogun what was the workaround, for reference?

CesarShogun commented 6 months ago

bar brawl fix I just made sure the bar will never appear by ticking those options (In Combat + Out of Combat)