Eranziel / foundryvtt-lancer

A Foundry VTT game system for LANCER RPG.
GNU General Public License v3.0
107 stars 64 forks source link

[BUG] Grenade Systems no longer show their Mine counterparts #680

Closed TheNittles closed 4 months ago

TheNittles commented 5 months ago

Describe the bug When you add a grenade system (HAVOK Charges were the one I noticed this with, but it's also at least happening with Hex charges) the entry on the character sheet no longer lists the effects of deploying the grenade as a mine. This appears to happen either when importing from CompCon or when manually adding a system.

To Reproduce Steps to reproduce the behavior:

  1. Add a grenade system to a player mech, either from the compendium or by importing a mech that has one.

Expected behavior The grenade system will have a second half of its entry that lists the effects of deploying it as a mine.

Screenshots image How the system appears on V11 image How it looked back in V10

Platform (please complete the following information):

Discord contact info If you are willing to answer questions regarding this bug report on Discord, or if you want to be notified when it is fixed, please leave your Discord ID here. Nittles

TheNittles commented 5 months ago

Upon further investigation, it appears any system that uses the Deployables section of the system sheet isn't showing that section on the character sheet. I noticed this with Webjaw Snares. You can see the deployable and corresponding action if you look at it in the compendium, but on the character sheet, nothing.

Eranziel commented 5 months ago

I believe this happens when you manually add the system by drag and drop from the compendium. It should not happen when importing from Comp/Con, unless something broke recently. See #649.

The fix is to open the deployable actor sheets (in the same folder as your nech actor), and drag the mech onto the deployable sheet. After that, opening the mech sheet will show the correct deployable cards. The wrong deployed getting set is a bug, so that will get fixed eventually.

Eranziel commented 5 months ago

Marking this as duplicate for now, unless there is some behaviour not already covered by #649.

TheNittles commented 5 months ago

I can open a new issue if you need, but once the mech is set as a deployer, the deployable does appear correctly, however, the action button for deploying them appears to be broken. Clicking it doesn't post the deployable's description to chat or decrement one of the uses of the deployable.

Eranziel commented 5 months ago

Deployable action buttons aren't implemented yet. ;-)